View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0005055||OXID eShop (all versions)||1.03. Basket, checkout process||public||2013-04-10 17:46||2015-10-05 12:15|
|Priority||normal||Severity||minor||Reproducibility||have not tried|
|Status||resolved||Resolution||unable to reproduce|
|Product Version||4.6.2 revision 46646|
|Target Version||4.6.7||Fixed in Version|
|Summary||0005055: oxbasket::getPaymentCosts() does not test for null return|
|Description||A shop owner reported bad (or even no) listings in the results for his articles in the Google search. His SEO consultant told him that the Google crawler/bot "gets stuck" somewhere on their page and quits indexing (I could not verify this of course).|
Their partner says that the error was this:
oxbasket::getPaymentCosts() calls oxbasket::getCosts which returns NULL if calculateBasket() was not performed in advance. Because of oxbasket::isEnabled() calculateBasket() is not performed if the shop is visited by a crawler.
Since getPaymentCosts does not check the return value of oxbasket::getCosts but instead calls the next function directly the script will abort.
|Steps To Reproduce||unknown.|
|Additional Information||Compare oxbasket::getFPaymentCosts().|
I know that the method was changed in 4.7.0.
Question: Is the missing check for null return values really a problem for crawlers?
|Tags||Basket, Calculations, Price Calculation|