View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003154 | OXID eShop (all versions) | 2.3. Extensions (modules, themes) | public | 2011-08-18 14:38 | 2012-12-10 13:33 |
| Reporter | csimon | Assigned To | |||
| Priority | high | Severity | major | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 4.5.1 revision 38045 | ||||
| Target Version | 4.6.0_beta2 | Fixed in Version | 4.6.0_beta2 | ||
| Summary | 0003154: Wrong comparision in listitem_line.tpl | ||||
| Description | Hi, in listitem line the TPrice comparision is wrong since 4.5.1: [{if $product->getFTPrice() > $product->getFPrice()}] These are the formatted prices, they return values with commas if you use german localization. The right one: [{assign var=$tprice value=$product->getTPrice() }] [{assign var=$regularprice value=$product->getPrice()}] [{if $tprice->getBruttoPrice() > $regularprice->getBruttoPrice() }] | ||||
| Tags | No tags attached. | ||||
| Theme | Azure | ||||
| Browser | All | ||||
| PHP Version | any | ||||
| Database Version | any | ||||
| has duplicate | 0003297 | resolved | dainius.bigelis | incorrect comparison: $oDetailsProduct->getFTPrice() > $oDetailsProduct->getFPrice() |
| related to | 0003619 | resolved | Linas Kukulskis | rrp not shown when price and rrp have different amount of digits |
|
|
Related to this report: http://www.oxid-esales.com/forum/showthread.php?t=10762&page=2#post65723 |
|
|
Note: this comparision is also made in several other files like compareitem.tpl, listitem_infogrid.tpl, listitem_grid.tpl. There could be even more occurences. |
|
|
note 2: this affects azure. forgot to select this, sorry. |
|
|
@developers: please, investigate |
|
|
Re-opening this bug. The bugfix provided was not correct. Please find the correct one in this forum post: http://www.oxid-esales.com/forum/showthread.php?p=81624#post76624 In listitem_infogrid.tpl, listitem_grid.tpl, listitem_line.tpl, please replace [{if $product->getFTPrice() > $product->getFPrice()}] by [{assign var="tprice" value=$product->getTPrice() }] [{assign var="regularprice" value=$product->getPrice()}] [{if $tprice->getBruttoPrice() > $regularprice->getBruttoPrice()}] In productmain.tpl please replace [{if $oDetailsProduct->getFTPrice() > $oDetailsProduct->getFPrice()}] by [{assign var="tprice" value=$oDetailsProduct->getTPrice() }] [{assign var="regularprice" value=$oDetailsProduct->getPrice()}] [{if $tprice->getBruttoPrice() > $regularprice->getBruttoPrice()}] Please double-check your changes manually! |
|
|
@Developers: please see bug entry 0003297 for more info |
|
|
checked from source code, all changed already added |
