View Issue Details

IDProjectCategoryView StatusLast Update
0003154OXID eShop (all versions)2.3. Extensions (modules, themes)public2012-12-10 13:33
Reportercsimon 
PriorityhighSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version4.5.1 revision 38045 
Target Version4.6.0_beta2Fixed in Version4.6.0_beta2 
Summary0003154: Wrong comparision in listitem_line.tpl
DescriptionHi,

in listitem line the TPrice comparision is wrong since 4.5.1:

[{if $product->getFTPrice() > $product->getFPrice()}]

These are the formatted prices, they return values with commas if you use german localization. The right one:

[{assign var=$tprice value=$product->getTPrice() }]
[{assign var=$regularprice value=$product->getPrice()}]
[{if $tprice->getBruttoPrice() > $regularprice->getBruttoPrice() }]

TagsNo tags attached.
ThemeAzure
BrowserAll
PHP Versionany
Database Versionany

Relationships

has duplicate 0003297 resolveddainius.bigelis incorrect comparison: $oDetailsProduct->getFTPrice() > $oDetailsProduct->getFPrice() 
related to 0003619 resolvedLinas Kukulskis rrp not shown when price and rrp have different amount of digits 

Activities

marco_steinhaeuser

2011-08-18 14:46

administrator   ~0005061

Related to this report:
http://www.oxid-esales.com/forum/showthread.php?t=10762&page=2#post65723

csimon

2011-08-18 14:48

reporter   ~0005062

Note:

this comparision is also made in several other files like compareitem.tpl, listitem_infogrid.tpl, listitem_grid.tpl. There could be even more occurences.

csimon

2011-08-18 14:57

reporter   ~0005063

note 2:

this affects azure. forgot to select this, sorry.

birute_meilutyte

2011-08-19 08:51

reporter   ~0005064

@developers: please, investigate

marco_steinhaeuser

2012-02-14 20:01

administrator   ~0005735

Re-opening this bug. The bugfix provided was not correct. Please find the correct one in this forum post:
http://www.oxid-esales.com/forum/showthread.php?p=81624#post76624

In listitem_infogrid.tpl, listitem_grid.tpl, listitem_line.tpl, please replace

[{if $product->getFTPrice() > $product->getFPrice()}]

by

[{assign var="tprice" value=$product->getTPrice() }]
[{assign var="regularprice" value=$product->getPrice()}]
[{if $tprice->getBruttoPrice() > $regularprice->getBruttoPrice()}]

In productmain.tpl please replace

[{if $oDetailsProduct->getFTPrice() > $oDetailsProduct->getFPrice()}]

by

[{assign var="tprice" value=$oDetailsProduct->getTPrice() }]
[{assign var="regularprice" value=$oDetailsProduct->getPrice()}]
[{if $tprice->getBruttoPrice() > $regularprice->getBruttoPrice()}]

Please double-check your changes manually!

dainius.bigelis

2012-02-29 16:20

reporter   ~0005844

@Developers: please see bug entry 0003297 for more info

Linas Kukulskis

2012-03-14 13:22

reporter   ~0005985

checked from source code, all changed already added