0007629: If the shop is running in net mode and a voucher is redeemed, an incorrect amount will be collected by PayPal - OXID eShop bugtrack

ID	Project	Category	View Status	Date Submitted	Last Update

0007629	module PayPal Checkout	module PayPal checkout - sub	public	2024-04-08 17:19	2024-05-10 14:43

Reporter	thomas_g	Assigned To
Priority	normal	Severity	major	Reproducibility	always
Status	resolved	Resolution	fixed
Product Version	2.3.3 / 1.3.3

Summary	0007629: If the shop is running in net mode and a voucher is redeemed, an incorrect amount will be collected by PayPal
Description	If the shop is running in net mode, the variable $itemTotal in OrderRequestFactory::getAmount() on line 205 already contains the discounted amount. The discount (net) is incorrectly deducted again in line 212. The resulting incorrect amount will be collected by PayPal. /** * @return AmountWithBreakdown */ protected function getAmount(): AmountWithBreakdown { $basket = $this->basket; $currency = $basket->getBasketCurrency(); //Discount $discount = $basket->getPayPalCheckoutDiscount(); //Item total cost 205 $itemTotal = $basket->getPayPalCheckoutItems(); // possible price surcharge if ($discount < 0) { $itemTotal -= $discount; $discount = 0; } 212 $total = $itemTotal - $discount;
Steps To Reproduce	1. Set the net mode in the Shop: Master Settings -> Core Settings -> Settings -> VAT -> Enter Product Prices as Net Prices (plus VAT) Master Settings -> Core Settings -> Settings -> VAT -> Show net prices in frontend (B2B) 2. Add one ore more articles to the basket 3. Go to the Checkout and redeem a voucher - absolute or relative doesn't matter 4. Choose PayPal as payment method 5. Go to the final checkout step and remember or write down the total amount 6. Click buy now 7. Log in to PayPal and check the payment amount => The net value of the voucher was deducted again from the final amount
Additional Information	- es -
Tags	No tags attached.