View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006578 | Flow theme | Theme | public | 2017-01-30 12:09 | 2018-09-20 09:58 |
| Reporter | keywan.ghadami | Assigned To | |||
| Priority | normal | Severity | crash | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Fixed in Version | 3.0.2 | ||||
| Summary | 0006578: Javascript error on mobile device on detail page breaks swipe | ||||
| Description | In mobile view on detail page there is an error that stops javascript from working. | ||||
| Steps To Reproduce | 1. mobile view (e.g. chrome F12, mobile symbol) 2. open/reload detail page e.g. http://demoshop.oxid-esales.com/professional-edition/Kiteboarding/Kiteboards/Kiteboard-CABRINHA-CALIBER-2011.html 3. look at the browser console you see something like: Uncaught ReferenceError: Carousel is not defined at HTMLDocument.<anonymous> (details.min.js?1477089128:1) at k (jquery.min.js?1477089128:2) at Object.fireWith [as resolveWith] (jquery.min.js?1477089128:2) at Function.ready (jquery.min.js?1477089128:2) at HTMLDocument.g (jquery.min.js?1477089128:1) (anonymous) @ details.min.js?1477089128:1 k @ jquery.min.js?1477089128:2 fireWith @ jquery.min.js?1477089128:2 ready @ jquery.min.js?1477089128:2 g @ jquery.min.js?1477089128:1 4. click on an image, it will leave the page instead of opening a slider | ||||
| Additional Information | 1. the problem is in detail.js, the code asks for if (window.isMobileDevice() ) and then calls "Carousel" which is not defined new Carousel( '#swipe-overlay' ); a good workaround might be to drop the if statement. 2. the java script error may cause additional effects, e.g. modules and other javascript might fail because of this issue, so please keep the severity to at least critical. | ||||
| Tags | Solution Provided | ||||
|
|
To make it work i also removed the condition in the productmain.tpl, so it will always init things: [{oxscript add="\$( document ).ready( function() { Flow.initDetailsEvents(); });"}]. |
|
|
pull request: https://github.com/OXID-eSales/flow_theme/pull/81 https://github.com/OXID-eSales/flow_theme/pull/82 |
|
|
Pull requests analyzed, tested and merged. Thanks. |
