View Issue Details

IDProjectCategoryView StatusLast Update
0006568OXID eShop (all versions)1.03. Basket, checkout processpublic2017-01-16 11:38
ReporterJCT Assigned To 
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version4.10.2 / 5.3.2 
Fixed in Version4.10.3 / 5.3.3 
Summary0006568: [Order Confirmation] Form field 'ord_agb' is not checked to be '1'
DescriptionThe parameter 'ord_agb' is totally ignored by the checkout process. It is possible to place a order without passing the parameter 'ord_agb' , 'ord_agb' could also be '0'.

In the shop configuration 'blConfirmAGB' is checked (user has to accept the terms and conditions).
TagsNo tags attached.
ThemeAll
BrowserAll
PHP VersionNot defined
Database VersionNot defined

Activities

JCT

2017-01-05 11:18

reporter   ~0011904

The mistake is in the 'fcPayOneOrderView.php' which is shipped with in OXID EE (maybe also PE) on line 347:

if(parent::_validateTermsAndConditions() === true); {

Should be:
if(parent::_validateTermsAndConditions() === true) {


The semicolon ignores the condition so that the 'if-block' (which actually does not belong to the if) is executed always!

marco_steinhaeuser

2017-01-05 15:29

reporter   ~0011905

This one is already fixed in the PayOne repository: https://github.com/PAYONE-GmbH/oxid-5/commit/630c1338d7354025a85879284c8bd7d59ecb734a

I reckon it will be merged with the next patch release.

florian.auer

2017-01-16 11:36

reporter   ~0011928

This has been fixed by Payone in their module. The new Payone module version 2.1.5 will be shipped with the upcoming OXID eShop 5.3.3 patch release.

florian.auer

2017-01-16 11:38

reporter   ~0011929

Fixed in Payone module v2.1.5, will be released within the OXID eShop 5.3.3 patch release.