View Issue Details

IDProjectCategoryView StatusLast Update
0006514module Visual CMSmodule Visual CMS - subpublic2018-03-26 16:08
ReporterKvist Assigned To 
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
PlatformAllOSAllOS VersionAll
Fixed in Version3.2.0 
Summary0006514: VisualCMS breaks Smarty tags with parameters
DescriptionWhen there are Smarty tags in a CMS page that have parameters, the VisualCMS editor destroys them. I think the reason this happens is because the editor mistakes the Smarty as HTML attributes and appends ="" to some parts because these "HTML attributes" have an empty value.
As an example, if I enter

<a href="[{oxgetseourl ident="4e4abe34121161e7ef82ace8b74fa732" type="oxcontent"}]">

the editor turns it into

<a href="[{oxgetseourl ident=" 4e4abe34121161e7ef82ace8b74fa732"="" type="oxcontent" }]"="">

This will break the engine when parsing and happens in the very moment when a part of a CMS page containing Smarty tags is opened to be edited and the only way to prevent the page from breaking, is to manually remove all the invalid contents, save the page and preferrably never edit it again.

We have tags like these in oxstartwelcome to greet a customer by name and to link to certain other CMS pages and the Shop . Whenever somebody edits that content without repairing all the broken tags, the whole shop is virtually unusable.
Steps To ReproduceWith VisualCMS turned off:

* Create a CMS page
* Add a Smarty tag with parameters
* Turn on VisualCMS module
* Edit the CMS page with VisualCMS
* Open the part containing the Smarty tag
* Switch to HTML
* Tag is broken


With VisualCMS turned on:

* Create a CMS page
* Add Text
* Edit HTML
* Add Smarty tag with parameters
* Switch to normal view
* Switch back again to source code
* Tag is broken
TagsNo tags attached.
Attached Files
vcms-before.png (133,745 bytes)   
vcms-before.png (133,745 bytes)   
vcms-html-off.png (131,051 bytes)   
vcms-html-off.png (131,051 bytes)   
vcms-after.png (133,718 bytes)   
vcms-after.png (133,718 bytes)   

Relationships

has duplicate 0006772 resolvedrobert blank parser is not working correctly 

Activities

QA

2016-09-29 15:09

administrator   ~0011809

The issue is not reproducible. Can you provide screenshots of the "before" and "after" html code mentioned in Steps to Reproduce?

Kvist

2016-09-30 11:34

reporter   ~0011810

I've added three screenshots. The first one is vcms-before. I created the page and a text element in it, switched to HTML view and added the tag you see.

In vcms-html-off, I've switched back to "normal" view right after vcms-before.

I've then switched back to HTML and got vcms-after.

The same effect would have occured if I created the page and the tag with VisualCMS turned off, then turned the module on and edited the element.

The tag is made invalid as soon as the editor gets it's hands on it.