View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006232 | OXID eShop (all versions) | 4.06. Language and translations | public | 2015-09-14 00:41 | 2023-07-06 10:04 |
| Reporter | hoekie | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | confirmed | Resolution | open | ||
| Product Version | 4.9.5 / 5.2.5 | ||||
| Summary | 0006232: Language Url param added, even if there is only one language available. | ||||
| Description | after updating to 4.9.5, i noticed a change in the behaviour of some URLs in my shop. It added ?lang=2 for all URLs that where processed by oxlang::processUrl() The shop only has ONE language available, so this is very annoying and bad for SEO! The reason is an update of core/oxlang.php Hint: $this->detectLanguageByBrowser() returns langID or null! So if you intval() that you'll get 0 ;) | ||||
| Steps To Reproduce | 1. install demoshop 2. change default language to a non standard language, e.g. Nederlands ID=2 3. keep at least 3 languages (e.g. EN=0,DE=1,NL=2) 4. browse the shop | ||||
| Tags | No tags attached. | ||||
| Theme | Other | ||||
| Browser | Not defined | ||||
| PHP Version | Not defined | ||||
| Database Version | Not defined | ||||
| related to | 0005775 | resolved | DefaultLanguage collabs language selection in frontend |
|
|
Your hint implies that the behaviour was introduced by the pull request which fixed 0005775? https://github.com/OXID-eSales/oxideshop_ce/pull/163 |
|
|
yes. omg, now i need to do a pull-request too... https://github.com/OXID-eSales/oxideshop_ce/pull/260 |
