View Issue Details

IDProjectCategoryView StatusLast Update
0006232OXID eShop (all versions)4.06. Language and translationspublic2015-10-01 22:31
Reporterhoekie 
PrioritynormalSeverityminorReproducibilityalways
Status acknowledgedResolutionopen 
Product Version4.9.5 / 5.2.5 
Target VersionFixed in Version 
Summary0006232: Language Url param added, even if there is only one language available.
Descriptionafter updating to 4.9.5, i noticed a change in the behaviour of some URLs in my shop. It added ?lang=2 for all URLs that where processed by oxlang::processUrl()

The shop only has ONE language available, so this is very annoying and bad for SEO!

The reason is an update of core/oxlang.php

Hint: $this->detectLanguageByBrowser() returns langID or null! So if you intval() that you'll get 0 ;)
Steps To Reproduce1. install demoshop
2. change default language to a non standard language, e.g. Nederlands ID=2
3. keep at least 3 languages (e.g. EN=0,DE=1,NL=2)
4. browse the shop
TagsNo tags attached.
ThemeOther
BrowserNot defined
PHP VersionNot defined
MySQL VersionNot defined

Relationships

related to 0005775 resolved DefaultLanguage collabs language selection in frontend 

Activities

martinwegele

2015-09-14 09:27

reporter   ~0011220

Your hint implies that the behaviour was introduced by the pull request which fixed 0005775?
https://github.com/OXID-eSales/oxideshop_ce/pull/163

hoekie

2015-10-01 22:31

reporter   ~0011230

Last edited: 2015-10-01 23:11

View 2 revisions

yes.

omg, now i need to do a pull-request too...
https://github.com/OXID-eSales/oxideshop_ce/pull/260