View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005254 | OXID eShop (all versions) | 1.02. Price calculations (discounts, coupons, additional costs etc.) | public | 2013-06-27 11:07 | 2015-03-19 14:04 |
| Reporter | EggSupport | Assigned To | |||
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | unable to reproduce | ||
| Product Version | 4.7.5 / 5.0.5 | ||||
| Target Version | 4.9.4 / 5.2.4 | ||||
| Summary | 0005254: Selectlists are not considered correctly | ||||
| Description | There is a problem with the correct calculation from selectlists. It's reconstructable in your demo shop and with simmilar problems in our live system. Weve got the bug since version 4.7.5. | ||||
| Steps To Reproduce | Create selectlists with +1000 abs and -1000 abs and try it for example with Kite FLYSURFER SPEED3 Total 1.439,10 € both. | ||||
| Additional Information | Try to put http://bestprotection.de/shop/Koerperschutzsysteme/Schutzwesten/UEberziehschutzwesten/Polizei-Schutzweste-BATEX.html with variant Gr. M and Schutzklasse SK2 +100 € into the basket. The sum is correct for the whole order and payment process, _but_ in the backend (and oxorder, oxorderarticles) the selectlist are not considered. OXID CE 4.7.6 | ||||
| Tags | Selection List | ||||
| Attached Files | |||||
| Theme | Both | ||||
| Browser | All | ||||
| PHP Version | any | ||||
| Database Version | any | ||||
|
|
Sorry, selectlist are _not_ beeing considered correctly |
|
|
aggrosoft create a little fix, see attached --- doesnt work all the time... maybe there more bugs edit 15-07-13 |
|
|
okay antother problem selectlist doesnt work with variants...(multidimensional) the price calculation crash if you change for example the pay date. |
|
|
--> https://bugs.oxid-esales.com/view.php?id=4624 Workaround --> http://forum.oxid-esales.com/showthread.php?t=18930&page=5#post127751 |
|
|
Do you mean that variants are not considered during order recalculation in backend? (e.g. updating amount of ordered items) We were trying to reproduce this bug, all selectlist prices are correctly calculated in basked, checkout process and later correctly displayed in backend. But in backend if order is updated (amount changed and order recalculated) then selectlist prices are not considered correctly. Could you specify the case with variants (multidimentional) that is not working properly for you as well? |
|
|
No, its the same you explain. Selectlist prices are not correctly calculate in backend if there any change in the order and the system recalculate. |
|
|
sorry, but how long it will take until the solution? |
|
|
attached a new fix - cmselectionlistsrecalculate.zip |
|
|
Reminder sent to: EggSupport Hi, As we saw, you already submitted a complete solution for this issue. If you feel fancy, you'd also have the possibility to contribute your changes directly to our GitHub repository on https://github.com/OXID-eSales/oxideshop_ce/. [^] Please leave a note there with the bug number you fixed so we can close this issue in the bug tracker." Best regards |
|
|
The attached fix by aggrosoft (oxorderbug.zip) is to change one line in oxorder::_setOrderArticles():/* AGGROSOFT BUG FIX , USE COMMA INSTEAD OF SPACE TO APPEND VAR SELECT */
$oOrderArticle->oxorderarticles__oxselvariant = new oxField( trim( $sSelList.', '.$oProduct->oxarticles__oxvarselect->getRawValue() ), oxField::T_RAW );This will separate the selected variant clearly from name-value-pairs which come from select lists. This is important for the shop to be able to "find" the last selection value again. If the selected selection contained a price surcharge this will not be taken into account correctly during recalculation of the order in the admin panel. This is a "child issue" of 0004624 and a possible fix is in cmselectionlistsrecalculate.zip (by Julian Rauscher from OXID Certified Solution Partner Business Level - Commodule UG in Freiburg). |
|
|
The issue could not be reproduced with the information provided so far. The "steps to reproduce" of the original report seem to imply that the config option " Support Price Modifications by Selection Lists " (bl_perfUseSelectlistPrice) was not activated in advance. This is not a bug. In note 8926 the reporter said that there is (only?) a problem with (multidimensional) variants and the recalculation in the admin panel (~ 0004624). The reporter confirmed in note 8938 that this is the wrong behaviour of this issue. However we were unable to reproduce the behaviour in the described way in a PE 4.9.3: If " Support Price Modifications by Selection Lists " is activated and a variant article with selection list is bought all prices are correct. Also setting the payment date or altering the amount in the order will not result in wrong prices (e.g. the price surcharge being ignored or such). Therefore this issue will be closed. Please reopen it with clear instructions on how to reproduce the behaviour if you think that the error persists. |
