View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005125 | OXID ERP Interface | OXID ERP Interface - sub | public | 2013-05-24 14:16 | 2015-05-04 15:19 |
| Reporter | martinwegele | Assigned To | |||
| Priority | normal | Severity | major | Reproducibility | have not tried |
| Status | resolved | Resolution | fixed | ||
| Product Version | 2.11.1_54476 | ||||
| Fixed in Version | 2.12.0 | ||||
| Summary | 0005125: Revision number of shop is cast as int | ||||
| Description | After moving to GitHub pkg.rev contains a string of numbers and letters, e.g. 6cda1e4d8b4c19047960cdce632a54033e6fe2ff for 5.0.5. But in OXERPCompatibility::getPkgRevision this is cast as an integer! Please check if this could cause problems. | ||||
| Additional Information | public function getPkgRevision($sBasePath = null) { $sFile = (!$sBasePath?getShopBasePath():$sBasePath).'/pkg.rev'; if (is_readable($sFile)) { return (int) trim(file_get_contents($sFile)); } // TODO: return newest (HEAD) return 9999999; } | ||||
| Tags | Git | ||||
| related to | 0005124 | resolved | Linas Kukulskis | OXID eShop (all versions) | getRevision casts revision number to int |
