View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0004713||OXID eShop (all versions)||4.07. Source code, Test||public||2012-11-17 15:41||2013-01-08 13:01|
|Product Version||4.7.0 / 5.0.0 revision 51243|
|Target Version||Fixed in Version||4.7.3 / 5.0.3 revision 54408|
|Summary||0004713: Make standard credit rating configurable|
|Description||currently a new user is assigned "1000" in the field "credit rating" (hard coded in oxUser.getBoni). This value should be configurable via the Admin interface.|
|Additional Information||Taken over from:|
It's a bug because hard coded values in source code are boo-boo :-)
|Tags||No tags attached.|
|@Developers: check from the source code side if this needed.|
Reminder sent to: marco_steinhaeuser
this method is with comment:
* No logic set, only returns "1000". You should extend this function
* according your needs.
* @return integer
that means if you use this functionality with some module make this function act as you want - overwrite it.
in standard shop this methods is not used anywhere. So i think we should not add any config option in admin. maybe it can be useful add to creditPass or similar module which is using this getBoni();
|info in comment|
Linas, I dare to say this:
> hard coded values in source code are boo-boo
So it is not about a feature request or something but a matter of code quality. Hard coded _values_ are an absolute no go even if it can be overwritten with a module. Even a config.inc.php variable would do a good job here ;)
Oh - I seldom read this reminders as I get a lot of notifications from bug tracker. Please ping me personally via Skype or something to catch me up for such issues.
|added config option iCreditRating, which can be defined in config file|