View Issue Details

IDProjectCategoryView StatusLast Update
0004713OXID eShop (all versions)4.07. Source code, Testpublic2013-01-08 13:01
Reportermarco_steinhaeuser 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version4.7.0 / 5.0.0 revision 51243 
Target VersionFixed in Version4.7.3 / 5.0.3 revision 54408 
Summary0004713: Make standard credit rating configurable
Descriptioncurrently a new user is assigned "1000" in the field "credit rating" (hard coded in oxUser.getBoni). This value should be configurable via the Admin interface.
Additional InformationTaken over from:
https://oxid.uservoice.com/admin/forums/31940-feature-requests/suggestions/500217-make-standard-credit-rating-configurable

It's a bug because hard coded values in source code are boo-boo :-)
TagsNo tags attached.
ThemeBoth
BrowserAll
PHP Versionany
MySQL Versionany

Activities

jurate.baseviciene

2012-11-19 10:03

reporter   ~0007894

@Developers: check from the source code side if this needed.

Linas Kukulskis

2012-11-19 10:18

reporter   ~0007896

Reminder sent to: marco_steinhaeuser

hi,

this method is with comment:

/**
     * No logic set, only returns "1000". You should extend this function
     * according your needs.
     *
     * @return integer
     */


that means if you use this functionality with some module make this function act as you want - overwrite it.
in standard shop this methods is not used anywhere. So i think we should not add any config option in admin. maybe it can be useful add to creditPass or similar module which is using this getBoni();

Linas Kukulskis

2012-12-12 17:45

reporter   ~0008117

info in comment

marco_steinhaeuser

2013-01-06 23:33

administrator   ~0008220

Linas, I dare to say this:
> hard coded values in source code are boo-boo

So it is not about a feature request or something but a matter of code quality. Hard coded _values_ are an absolute no go even if it can be overwritten with a module. Even a config.inc.php variable would do a good job here ;)

Oh - I seldom read this reminders as I get a lot of notifications from bug tracker. Please ping me personally via Skype or something to catch me up for such issues.

Linas Kukulskis

2013-01-08 13:01

reporter   ~0008236

added config option iCreditRating, which can be defined in config file