View Issue Details

IDProjectCategoryView StatusLast Update
0004325OXID eShop (all versions)2.6. Administer orderspublic2012-12-10 13:17
Reporterd3 Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionwon't fix 
Product Version4.6.3 revision 47975 
Summary0004325: wrong function change
Descriptionmyorder.php change the original method getOrderArticles() and create following problem:

For example the function is used in first time maybe with storno = true, you can't change the articlelist later in the object to get all articles include stornoarticles.

The original method in oxorder make it right:

        if ( $blExcludeCanceled ) {

            return $this->_getArticles( true );

        }
        .....

TagsPDF Invoice
ThemeBoth
BrowserAll
PHP Versionany
Database Versionany

Activities

d3

2012-08-07 19:29

reporter   ~0007254

General problem is:
With "if ( $this->_oArticles == null) ..." you can't change the articlelist with another "storno status".

possible solution:

if ( $this->_oArticles == null || $this->blListStornoStatus != $blStorno)
{
    ....
    $this->blListStornoStatus = $blStorno;
}

aurimas.gladutis

2012-11-16 10:52

reporter   ~0007878

Hi, we checked this place and everything seems to work like expected. If you do want to change functionality, you can just rewrite that place and add needed functionality.

If we missed something, please reopen this bug and give some more details on why this needs to be changed.