View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004212 | OXID eShop (all versions) | 1.02. Price calculations (discounts, coupons, additional costs etc.) | public | 2012-07-02 13:07 | 2014-04-23 10:16 |
| Reporter | d3 | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Target Version | 4.8.5 / 5.1.5 | Fixed in Version | 4.8.5 / 5.1.5 | ||
| Summary | 0004212: Valid USTID-Numbers are considered incorrect | ||||
| Description | The prefix from the number is not an ISO-Alpha2. Especially for Greece: the prefix is "EL" but the ISO-Code is "GR". So every check for an USTID from Greece return an failure. | ||||
| Additional Information | A solution is not to change the ISO-Code, because some modules use the code. Maybe a new field "oxustidprefix" can change this. | ||||
| Tags | Country, VAT | ||||
| Theme | Both | ||||
| Browser | All | ||||
| PHP Version | any | ||||
| Database Version | any | ||||
| related to | 0004881 | resolved | Linas Kukulskis | wrong VAT-ID does not show error to user in frontend |
|
|
in oxcountry table ISO-Alpha2 is GR for Greece |
|
|
The ISO-Alpha2 for Greece is GR. But that VAT identification number for Greece start wie ELXXXXX. http://en.wikipedia.org/wiki/VAT_identification_number So every check for an USTID from Greece return an failure. |
|
|
Reminder sent to: d3 do you mean that oxonlinevatidcheck::checkUid( 'EL....') returns false? it should not, because: $oCheckVat = new stdClass(); $oCheckVat->countryCode = substr( $sCompVatId, 0, 2); $oCheckVat->vatNumber = substr( $sCompVatId, 2); it extract abbreviation from companyvatID, it does not used country ISO-Alpha2 code |
|
|
no, it's in oxinputvalidator::checkVatId() (4.7.2) if ( strncmp( $aInvAddress['oxuser__oxustid'], $oCountry->oxcountry__oxisoalpha2->value, 2 ) ) { ... } in this case the oxisoalpha2 for Greece is "GR", but that VAT identification number for Greece start with ELXXXXX. Greece is that on special case ;-) |
|
|
additionally a forum-user reported, that Azure does not show an error notice to the user when inserting a defenitely wrong VAT-ID into invoice-address while checkout http://forum.oxid-esales.com/showthread.php?p=114827#post114827 try in demoshop with account admin|admin and insert xy-1234567 into VAT-ID-field of invoice-adress opened a separate bug-entry for this issue: 0004881 |
|
|
That problem still exist. |
|
|
Fixed: added getVATIdentificationNumberPrefix method to oxcountry class, which is used in oxInputValidator class: if ( strncmp( $aInvAddress['oxuser__oxustid'], $oCountry->getVATIdentificationNumberPrefix(), 2 ) ) { ... } |
