View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003265 | OXID eShop (all versions) | 1.03. Basket, checkout process | public | 2011-09-22 08:53 | 2018-11-19 14:52 |
| Reporter | arvydas_vapsva | Assigned To | |||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | no change required | ||
| Product Version | 4.5.1 revision 38045 | ||||
| Summary | 0003265: [oxid-dev-general] Implementation of "TrustedShops Käuferschutz" is reason of huge Payment Problems | ||||
| Description | on 16.9. we released our newest Project on an OXID EE 4.5.1. Today the finacial accounter told me that he has a lot of payments, that did not execute an order. Usually I would search in the paymentmodule. But the problem was not continuous and it just happened in connection with the "Trusted Shop Käuferschutz". I Looked in the source and found a almost criminal part of native Oxid code in the finalizeOrder function of oxorder. // executing payment (on failure deletes order and returns error code) // in case when recalcualting order, payment execution is skipped if ( !$blRecalculatingOrder ) { $blRet = $this->_executePayment( $oBasket, $oUserPayment ); if ( $blRet !== true ) { return $blRet; } } // executing TS protection if ( !$blRecalculatingOrder && $oBasket->getTsProductId()) { $blRet = $this->_executeTsProtection( $oBasket ); if ( $blRet !== true ) { return $blRet; } } This means to me that first a payment is executed and THEN depending on the success of a Trustedshops call Order will be saved or skipped. I Looked at the Orders and I found, some orders with successful Trusted Shops Calls. but ther must be many, that failed an Money was already sent. In my opinion there shouldnt be any interface call after a payment, that could prohibit the execution of the order. Please share some thoughts about a better Implementation of TrustedShops Käufeschutz within the finalizeOrder. | ||||
| Tags | Basket, Trusted Shops | ||||
| Theme | Not defined | ||||
| Browser | All | ||||
| PHP Version | Not defined | ||||
| Database Version | Not defined | ||||
|
|
At that moment when the issue occured, fast fix was implemented, to proceed the order, without matter on got response from Trusted Shops. So order is saved anyway. Now we are discussing with Trusted Shops about their API and possibility to pre-check the status of the request (to do pre-check before order is submited, and save the particular status from TS to the order always). |
|
|
Since 6.1 TrustedShops has a dedicated module: https://exchange.oxid-esales.com/Legal-and-Security/Legal/Trusted-Shops-trustmark-customer-reviews-2-0-1-Stable-EE-PE-4-10-x-5-3-x-6-1-x.html -MK |
