View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003113 | OXID eShop (all versions) | 3.1. Design, GUI, UX | public | 2011-08-05 11:03 | 2011-09-16 09:05 |
| Reporter | marco_steinhaeuser | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 4.5.0 revision 34568 | ||||
| Fixed in Version | 4.5.3 revision 39087 | ||||
| Summary | 0003113: limit for product history shouldn't be hard coded | ||||
| Description | In loadHistoryArticles() theres a hardcoded limit for 4 articles, should be replaced by a config variable. | ||||
| Additional Information | http://www.oxid-esales.com/forum/showthread.php?t=10702 | ||||
| Tags | No tags attached. | ||||
| Theme | Both | ||||
| Browser | All | ||||
| PHP Version | any | ||||
| Database Version | any | ||||
|
|
details::getLastProducts( $iCnt = 4 ) and oxArticleList::loadHistoryArticles( $sArtId, $iCnt = 4 ) now has a parameter $iCnt, so you can define requested product count from template (adapt to your custom design). E.g. now in "last_seen_products.tpl" you can simply change current: [{assign var="aLastProducts" value=$oView->getLastProducts() }] into: [{assign var="aLastProducts" value=$oView->getLastProducts(9) }] Besides, intruduction of new config variables in similar cases is a bad example - we will trash database with parameters, which are rarelly used, but always loaded. So if possible, these should be used directly where they are needed - in template. |
