View Issue Details

IDProjectCategoryView StatusLast Update
0003113OXID eShop (all versions)3.1. Design, GUI, UXpublic2011-09-16 09:05
Reportermarco_steinhaeuser 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version4.5.0 revision 34568 
Target VersionFixed in Version4.5.3 revision 39087 
Summary0003113: limit for product history shouldn't be hard coded
DescriptionIn loadHistoryArticles() theres a hardcoded limit for 4 articles, should be replaced by a config variable.
Additional Informationhttp://www.oxid-esales.com/forum/showthread.php?t=10702
TagsNo tags attached.
ThemeBoth
BrowserAll
PHP Versionany
Database Versionany

Activities

arvydas_vapsva

2011-09-16 09:04

reporter   ~0005232

details::getLastProducts( $iCnt = 4 ) and oxArticleList::loadHistoryArticles( $sArtId, $iCnt = 4 ) now has a parameter $iCnt, so you can define requested product count from template (adapt to your custom design).

E.g. now in "last_seen_products.tpl" you can simply change current:

[{assign var="aLastProducts" value=$oView->getLastProducts() }]

into:

[{assign var="aLastProducts" value=$oView->getLastProducts(9) }]

Besides, intruduction of new config variables in similar cases is a bad example - we will trash database with parameters, which are rarelly used, but always loaded. So if possible, these should be used directly where they are needed - in template.