View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0000893 | OXID eShop (all versions) | 4.09. SEO, SEO URL | public | 2009-05-14 09:04 | 2012-12-10 13:35 |
Reporter | arvydas_vapsva | Assigned To | |||
Priority | normal | Severity | minor | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Product Version | 4.1.2 revision 18998 | ||||
Fixed in Version | 4.1.3 revision 19918 | ||||
Summary | 0000893: Unable to delete SEO meta keywords/description | ||||
Description | When you enter meta description or keywords in admin, you can not delete them any more | ||||
Tags | No tags attached. | ||||
Theme | |||||
Browser | All | ||||
PHP Version | 5.2.6 | ||||
Database Version | 5.0.33 | ||||
|
problem is in oxSeoEncoder::_saveToDb() method, and keyword/description value check: $sKeywords = $sKeywords ? $oDb->quote( $oStr->htmlentities( $this->encodeString( strip_tags( $sKeywords ), false ) ) ) : false; $sDescription = $sDescription ? $oDb->quote( $oStr->htmlentities( strip_tags( $sDescription ) ) ) : false; should be replaced by: if ( $sKeywords !== false ) { $sKeywords = $oDb->quote( $oStr->htmlentities( $this->encodeString( strip_tags( $sKeywords ), false ) ) ); } if ( $sDescription !== false ) { $sDescription = $oDb->quote( $oStr->htmlentities( strip_tags( $sDescription ) ) ); } But replacing is not a fix in general, as other standart calls are affected by this problem - default value should be false, instead previous ''.. So fix comes with next version |