View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007863 | module PayPal Checkout | module PayPal checkout - sub | public | 2025-12-01 10:18 | 2025-12-05 14:48 |
| Reporter | fcos | Assigned To | |||
| Priority | normal | Severity | major | Reproducibility | have not tried |
| Status | resolved | Resolution | fixed | ||
| Product Version | 2.6.3 / 3.5.1 | ||||
| Target Version | 2.6.4 / 3.5.2 | Fixed in Version | 2.6.4 / 3.5.2 | ||
| Summary | 0007863: Wrong return value causes error and canceled payments with captured money | ||||
| Description | Hello, since the update to 3.5.1 we see sometimes the folling error in oxideshop.log, wich causes the order to be canceled even if the capture was successful. OXID Logger.ERROR: OxidSolutionCatalysts\PayPal\Service\Payment::getCustomIdParameter(): Return value must be of type string, null returned ["[object] (TypeError(code: 0): OxidSolutionCatalysts\\PayPal\\Service\\Payment::getCustomIdParameter(): Return value must be of type string, null returned at /usr/www/users/customer/htdocs/vendor/oxid-solution-catalysts/paypal-module/src/Service/Payment.php:945)\n[stacktrace]\n#0 /usr/www/users/customer/htdocs/vendor/oxid-solution-catalysts/paypal-module/src/Service/OrderManager.php(82): OxidSolutionCatalysts\\PayPal\\Service\\Payment->getCustomIdParameter()\n#1 /usr/www/users/customer/htdocs/vendor/oxid-solution-catalysts/paypal-module/src/Controller/AjaxPaymentController.php(556): OxidSolutionCatalysts\\PayPal\\Service\\OrderManager->createShopOrder()\n#2 /usr/www/users/customer/htdocs/vendor/oxid-esales/oxideshop-ce/source/Core/Controller/BaseController.php(511): OxidSolutionCatalysts\\PayPal\\Controller\\AjaxPaymentController->createShopOrder()\n#3 /usr/www/users/customer/htdocs/vendor/oxid-esales/oxideshop-ce/source/Core/ShopControl.php(304): OxidEsales\\EshopCommunity\\Core\\Controller\\BaseController->executeFunction()\n#4 /usr/www/users/customer/htdocs/vendor/oxid-esales/oxideshop-ce/source/Core/ShopControl.php(238): OxidEsales\\EshopCommunity\\Core\\ShopControl->executeAction()\n#5 /usr/www/users/customer/htdocs/vendor/oxid-esales/oxideshop-ce/source/Core/ShopControl.php(123): OxidEsales\\EshopCommunity\\Core\\ShopControl->process()\n#6 /usr/www/users/customer/htdocs/vendor/oxid-esales/oxideshop-ce/source/Core/Oxid.php(27): OxidEsales\\EshopCommunity\\Core\\ShopControl->start()\n#7 /usr/www/users/customer/htdocs/source/index.php(22): OxidEsales\\EshopCommunity\\Core\\Oxid::run()\n#8 {main}\n"] [] The problem is the return type thats not checked and could be false, int or null depending on the circumstances. I hope you can look into it and fix this behaviour. | ||||
| Tags | No tags attached. | ||||