View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007758 | OXID eShop (all versions) | 7. --- Other tools -------------- | public | 2024-12-30 11:17 | 2024-12-31 09:56 |
| Reporter | cgsmith | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | N/A |
| Status | closed | Resolution | duplicate | ||
| Summary | 0007758: oxid-esales/smarty-to-twig-converter should contain composer lock | ||||
| Description | I recommend committing the composer.lock file to the repository: Composer also recommends this since it is not a library (https://getcomposer.org/doc/01-basic-usage.md#commit-your-composer-lock-file-to-version-control) If it was a library you could still technically commit the lock file and composer would ignore it if the smarty-to-twig-converter was used as a dependency of a project. Since there are no dependents of this code it is okay to commit the lock file. I have made a pull request. https://github.com/OXID-eSales/smarty-to-twig-converter https://packagist.org/packages/oxid-esales/smarty-to-twig-converter/dependents?order_by=downloads | ||||
| Tags | No tags attached. | ||||
| Theme | Not defined | ||||
| Browser | Not defined | ||||
| PHP Version | Not defined | ||||
| Database Version | Not defined | ||||
|
|
Hey @cgsmith thank you for the proposal! I will bring up this topic when I speak to the development team and since you've already opened up a pull request I will close the entry in our bugtracker and we keep track there (https://github.com/OXID-eSales/smarty-to-twig-converter/pull/3). I use as resolution the status duplicate, since it's kinda the most fitting. Kind regards Michael |
