View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007721 | OXID eShop (all versions) | 1.03. Basket, checkout process | public | 2024-09-16 14:23 | 2024-09-16 15:17 |
| Reporter | b.blasius | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | acknowledged | Resolution | open | ||
| Product Version | 7.1.0 | ||||
| Summary | 0007721: Order remark always 1 when no remark input in frontend | ||||
| Description | If you remove the order remark input field from frontend oxorder oxremark is always saved with value 1. This is due the wrong usage of the second parameter of getRequestParameter() in vendor/oxid-esales/oxideshop-ce/source/Application/Component/UserComponent.php:726 $sOrderRemark = Registry::getRequest()->getRequestParameter('order_remark', true); $sOrderRemark is set with default value true which makes no sense regarding the following code. I think this is a migration error from OXID 6 to 7. In OXID 6 $sOrderRemark = Registry::getConfig()->getRequestParameter('order_remark', true); makes sense. Second parameter is "raw" but in OXID 7 it is the default value. | ||||
| Tags | No tags attached. | ||||
| Theme | Not defined | ||||
| Browser | Not defined | ||||
| PHP Version | 8.1 | ||||
| Database Version | MySQL 5.7 | ||||
|
|
As of my testing, to reproduce, you need to select to change the shipping address and go forward afterwards because the mentioned line of code is not called if you go through checkout without (implying) to change something. However, it's reproducible and the idea it's a migration error might be true. Thank you for the report. [sp] |
