|
|
Fix for this issue: 1. services.yaml extend OxidSolutionCatalysts\PayPal\Service\OrderRepository with your own OrderRepository class (extending the original) 2. overwrite the cleanUpNotFinishedOrders: and replace query part ->andWhere('(oxorderdate + interval :sessiontime MINUTE) < now()'); |
|
|
Thank you for your Report. As for my understanding the method does not delete orders from the future but from the last :sessiontime gap. Let's say the :sessiontime parameter is 10 minutes and the order is 5 minutes old. The time of the order plus the session time of 10 minutes is 5 minutes in the future and will therefore be deleted even though the order is 5 minutes in the past. If an order is older than 10 minutes, it won't be deleted anymore. Ich will contact the project team and ask for the correct intention here. At last I want to ask you to be friendly and objective in Bugtracker. No software is perfect and we are open and happy about any report and investigate the issue carefully. So please concentrate on the issues and avoid headlines like "Missing Quality Control" and similar statements. Thank you. [sp] |
|
|
I can help you with the intention of the function: You can check the description in the admin module configuration (origin of the sessiontime value configuration): "Wie alt müssen nicht beendete Bestellungen sein, damit sie frühestens automatisch storniert werden (in Minuten)?" (see screenshot) Yes I now being wrong can be really hard, and our brain searches for every clue to support our wrongness: "Let's say the :sessiontime parameter is 10 minutes and the order is 5 minutes old." => replace order with temporary order and this results even in a worse bug => default value is 20min => delete all temporary orders from the last 20min => this includes even temporary orders that are still required for valid checkouts Quality Control: If you really want to make some improvements: Test your features. Blind programming is just begging for bugs. (and I am a bit annoyed because I had already mail contact with one of your developers and told him about the ordernumber = 0 check, preventing the deleting of old temporary orders. This issue is now fixed but your included a new bug => so Quality Control is missing here for sure) image.png (145,763 bytes) |
|
|
The project team is working on your reports. I ask you once again to keep it objective and dismiss offensive statements. This is not the place for it. [sp] |
- Anonymous
