View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007428 | OXID eShop B2B Edition | B2B edition - sub | public | 2023-02-24 15:15 | 2023-03-16 17:41 |
| Reporter | OxidSimonGassenschmidt | ||||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | confirmed | Resolution | open | ||
| Product Version | 5.0.0 | ||||
| Target Version | Fixed in Version | ||||
| Summary | 0007428: Vouchers according to comment not allowed, but useable anyway | ||||
| Description | Vouchers in B2B Edition are not allowed according to comments in methods OxidEsales\B2BModule\Basket\Model\B2b\Basket::setBasket and OxidEsales\B2BModule\Basket\Service\EditService::setBasket. /vendor/oxid-esales/b2b-basket-module/Model/B2b/Basket.php:89 /** * Sets the basket to the EshopUserBasketModel. * NOTE: Vouchers are not allowed in b2b. * * @param \OxidEsales\Eshop\Application\Model\Basket $basket The basket to set. */ public function setBasket($basket): string But adding a voucher in basket is possible anyway and you are also able to order with active voucher. Vouchers are only deleted on basket changes due to method OxidEsales\B2BModule\Basket\Model\Basket::removeAllVouchersForB2B called in OxidEsales\B2BModule\Basket\Service\EditService::setBasket. | ||||
| Steps To Reproduce | 1. Install OXID eShop 2. Install B2B Modules 3. Mark an User as B2B User 4. Create a Voucher 5. Login with B2B user. 6. Add product to basket. 7. Add voucher in basket. 8.1 Change anything in baske (e.g. item amount). Voucher is removed. You can add voucher again afterwards. or 8.2 Complete the order. Voucher is accepted as usual. | ||||
| Tags | No tags attached. | ||||
|
|
Both described issues are reproducable: Voucher is removed after basket changes and order including voucher is possible. I added some more information to your report. Product Management must decide about behavior in B2B Edition. Whether voucher is not allowed and input should be blocked directly or voucher is allowed. Then comments as well as removing on basket changes must be removed. [sp] |
