View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007363 | module PayPal Checkout | module PayPal checkout - sub | public | 2022-10-11 09:09 | 2022-10-11 14:37 |
| Reporter | QA | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 2.2.0 / 1.2.0 | ||||
| Fixed in Version | Next Minor PayPal version | ||||
| Summary | 0007363: Standard payment methods in the shop with activated net mode are not checked and are therefore not displayed. | ||||
| Description | As soon as the PayPal module is active, the Oxid standard payment methods, such as prepayment or invoice, are no longer displayed, although they are active and correctly assigned in the backend. If I deactivate the PayPal Checkout module, the payment methods are visible to the buyer again. Standard payment methods in the shop with activated net mode are not checked and are therefore not displayed. Customer operate the shop in net mode. The method getPaymentList() within the PaymentController seems to have been adapted from version 2.1.5. | ||||
| Steps To Reproduce | 1. Activate PayPal Checkout >= v2.1.5 2. Activate Netto Mode 3. Do a Ckeckout | ||||
| Additional Information | In 2.1.4, there is a check in modules/osc/paypal/src/Controller/PaymentController::getPaymentList() $payPalDefinitions[$key]['onlybrutto'] == false || ( $payPalDefinitions[$key]['onlybrutto'] == true && !$this->getServiceFromContainer(ModuleSettings::class)->isPriceViewModeNetto() ) Since oxidinvoice, for example, is not a PayPal payment type, the condition is true because the key does not exist in this array. In version 2.2.0. (presumably from 2.1.5) the check looks like this: $payPalDefinitions[$key]['onlybrutto'] === false || ( !$this->getServiceFromContainer(ModuleSettings::class)->isPriceViewModeNetto() ) This causes a standard payment method in the shop with activated net mode to be dropped from the check. - es - | ||||
| Tags | No tags attached. | ||||
|
|
@QA: Please checkout the actual dev-branch b-6.5.x or b-6.1.x and test it. |
|
|
Fixed with commit: b-6.5.x: https://github.com/OXID-eSales/paypal-module/commit/f9556a1e407505055bab3f2bf5cc508e6bcaf263 b-6.1.x: https://github.com/OXID-eSales/paypal-module/commit/eae86880ce958dd365349bb967238bd4e0eac211 |
