View Issue Details

IDProjectCategoryView StatusLast Update
0006979Wave themeThemepublic2019-07-31 14:04
ReporterBeckerEnterprises 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version1.1.0 
Target VersionFixed in VersionNext Minor version 
Summary0006979: remove from compare list link will never be displayed - missing variable prefix
DescriptionFirst line of file /tpl/page/details/inc/compare_links.tpl is:
[{if $in_list}]

and have to be:
[{if $_compare_in_list}]
TagsNo tags attached.

Activities

QA

2019-05-06 11:13

administrator   ~0012881

First line of file /tpl/page/details/inc/compare_links.tpl is [{if $in_list}] and remove from compare list link will be displayed (see Screenshot).

compare_list.JPG (64,535 bytes)
compare_list.JPG (64,535 bytes)

BeckerEnterprises

2019-05-06 15:48

reporter   ~0012884

The compare_links.tpl contains the add and remove links on product details page not the compare list itself.
The smarty function oxid_include_dynamic adds a prefix to the given parameter which is missing for $in_list, correct is: $_compare_in_list.

In the current state you are not able to remove product from product details page, the link also would change from "Vergleichen" to "Aus Vergl. entfernen".

demo.jpg (26,831 bytes)
demo.jpg (26,831 bytes)

QA

2019-05-07 08:04

administrator   ~0012885

ok you are right. First line of file /tpl/page/details/inc/compare_links.tpl is:

[{if $in_list}]
but has to be:
[{if $_compare_in_list}]
to show the remove link instead of add link if article is in compare_list.

- es -

compare_list_2.JPG (70,759 bytes)
compare_list_2.JPG (70,759 bytes)
compare_list_1.JPG (70,590 bytes)
compare_list_1.JPG (70,590 bytes)

Alpha-Sys

2019-07-24 21:51

reporter   ~0012949

I created a pull request to fix this bug: https://github.com/OXID-eSales/wave-theme/pull/59