View Issue Details

IDProjectCategoryView StatusLast Update
0006955module PayPalmodule PayPal - subpublic2019-04-18 17:56
ReporterStefan_Werner Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version5.2.3 
Fixed in Version5.2.4 
Summary0006955: Empty payment methods are created if used in auto module activation enviroment
DescriptionEmpty Payment methods are created if you use config export and import on OXID SDK
Steps To ReproduceExport config with disabled paypal module
import config
Empty Payment method created
Best to reproduce on OXID eShop SDK
Additional Informationto fix

oxideshop/source/modules/oe/oepaypal/Core/Events.php::disablePaymentMethod()

add an if

    /**
     * Disables PayPal payment method
     */
    public static function disablePaymentMethod()
    {
        $payment = oxNew(\OxidEsales\Eshop\Application\Model\Payment::class);
        if ($payment->load('oxidpaypal')) {
            $payment->oxpayments__oxactive = new \OxidEsales\Eshop\Core\Field(0);
            $payment->save();
        }
    }
TagsNo tags attached.

Activities

QA

2019-02-25 09:30

administrator   ~0012794

As far as I understand there are three steps, which have to be done:

1) Export the config.
2) Import the config.
3) Auto-activate the modules (with a module).

All three steps are linked to third-party modules, like the ones from the OXID SDK. The functionalities - im-/export as well as auto-activation - are not part of the standard tool kit of an OXID eShop. The so called OXID SDK modules are also not maintained by OXID itself.

Furthermore I identify the problem in the task chain of the im-/export behavior. The module exports only the config values for the PayPal module but not the refered payments. Then you import these config values into another shop. After that the auto activation is used and triggers the onActivate-Event from the PayPal module which can't find the relevant payment methods which are refered by the config values.

To sum it up, I'm unable to identify a wrong behavior in the PayPal module. I would say that it's more of a difficulty in the im-/export module.

Since it is a very special use case, there might be some misunderstanding on my side. If this is the case, I would appreciate some more feedback from you.

[sp]

anton.fedurtsya

2019-03-12 15:24

administrator   ~0012817

Hello, the PR with a fix is merged: https://github.com/OXID-eSales/paypal/pull/50