View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0006950 | Wave theme | Theme | public | 2019-02-07 11:27 | 2024-06-12 09:03 |
Reporter | mario_lorenz | Assigned To | |||
Priority | normal | Severity | minor | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Fixed in Version | 1.3.0 | ||||
Summary | 0006950: Grunt Concat JS: Some libs are concat, even though they are extra loaded | ||||
Description | These resources are also bundled into the javascript.js, although they are still loaded in the templates additionally. '<%= project.dev %>build/vendor/jquery-flexslider2/js/jquery.flexslider.js', '<%= project.dev %>build/js/pages/compare.js', '<%= project.dev %>build/js/pages/details.js', '<%= project.dev %>build/js/pages/review.js', '<%= project.dev %>build/js/pages/start.js' | ||||
Additional Information | Solution: Either the resources are not bundled, or the extra loadings disappear in the templates. | ||||
Tags | No tags attached. | ||||
|
Where do you see a usage of javascript.js in wave theme? -MF |
|
@QA: to bundle the files is your first step. After this you uglify the javascript.js to scripts.min.js. Your mistake is, that you load in ... \tpl\page\shop\start.tpl -> js/pages/start.min.js \tpl\page\details\inc\productmain.tpl -> js/pages/details.min.js ... the files seperatly. Only in ... \tpl\page\review\review.tpl \tpl\page\compare\compare.tpl ... did you´ve comment out the js includes. |
|
Fixed in v1.3.0 |