View Issue Details

Jump to Notes
IDProjectCategoryView StatusDate SubmittedLast Update
0006937Flow themeThemepublic2019-01-03 11:122019-01-07 08:37
Reporterggenute Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status acknowledgedResolutionopen 
Summary0006937: In product detail view the Manufacturer icon's link doesn't work correctly
DescriptionThe issue is about Manufacturer articles list display. If Master Settings->Core Settings->Perform. setting “Load and display Manufacturer List” is active everything it’s ok (In the footer there is a list of Manufacturers, in the product detail view the Manufacturer icon is like link and it works fine).

If the setting is inactive, in the footer there is no list of brands, but in the product detail view the Manufacturer icon still is like link and it doesn’t work.
Steps To ReproduceIn shop admin area->Master Settings->Core Settings->Perform. deactivate setting “Load and display Manufacturer List”. In the product detail view click on Manufacturer icon
Additional InformationI founded, that the change was made in tpl/page/list/list.tpl: https://github.com/OXID-eSales/flow_theme/pull/98
[{$actCategory->getTitle()}] from [{$oView->getTitle()}]

If the changes are restored, the Manufacturer icon's link works. But the link goes to an empty Manufacturer products list. It has to be changed as well.
When setting “Load and display Manufacturer List” is deactivated my suggestion to would be:
a) the Manufacturer icon’s link in product detail view has to be removed
OR
b) the Manufacturer icon works like link and it works - displays all products of that Manufacturer, but only Manufacturers are not displayed in the footer.
TagsNo tags attached.
Attached Files
link_result.png (33,403 bytes)   
link_result.png (33,403 bytes)   
link.png (238,720 bytes)   
link.png (238,720 bytes)   
empty_list.png (26,369 bytes)   
empty_list.png (26,369 bytes)   

Activities

QA

2019-01-03 11:40

administrator   ~0012751

I tried to reproduce the issue. In an OXID eShop 6.1.1 standard installation the link works fine - without restoring anything like metioned in "Additional Information". Nonetheless, as also described, an empty manufacturer products list is shown. Therefore there is an issue in fact.

[sp]

ggenute

2019-01-03 13:27

reporter   ~0012752

Last edited: 2019-01-03 13:38

 Earlier I tested on Enterprise Edition 6.1.1 and the issue was as I described before. It's strange because it's default eshop project. Now I reinstalled the eshop one more time and it works. Maybe there was some more specific situation.
For now the empty manufacturer products list is shown.

ggenute

2019-01-03 14:31

reporter   ~0012753

I founded the situation:
The EE 6.1.1 uses flow theme in list.tpl 35 line there is still [{$oView->getTitle()}] That's why it works.

And earlier I had latest flow theme version (used from github): Branch master contain Flow for OXID eShop b-6.x branch latest development 35 line there is [{$actCategory->getTitle()}]

Branch b-1.0 contains Flow for OXID eShop version 4.10/5.3 => tpl/page/list/list.tpl 35 line there is still [{$oView->getTitle()}]
Branch b-2.x contains Flow for OXID eShop version 6.0.0 => 35 line there is still [{$oView->getTitle()}]

QA

2019-01-07 08:37

administrator   ~0012754

Last edited: 2019-01-07 08:37

 Reproduced with the information from the comment #c12753.
Added the info to the not yet merged pull request: https://github.com/OXID-eSales/flow_theme/pull/98#issuecomment-451846253

-MK