View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006886 | OXID eShop (all versions) | 6. ------ Setup ------- | public | 2018-08-14 11:46 | 2022-01-28 10:14 |
| Reporter | kaluzki | ||||
| Priority | normal | Severity | feature | Reproducibility | always |
| Status | resolved | Resolution | won't fix | ||
| Product Version | |||||
| Target Version | Fixed in Version | ||||
| Summary | 0006886: exclude tests from dist-packages | ||||
| Description | @see https://madewithlove.be/gitattributes/ | ||||
| Tags | Composer, Git | ||||
| Theme | Not defined | ||||
| Browser | Not defined | ||||
| PHP Version | Not defined | ||||
| Database Version | Not defined | ||||
|
|
The testing library is included for development purpose but can be excluded during installation with the paramater --no-dev, which is recommended for a production installation. It is described in our docs: https://docs.oxid-esales.com/developer/en/6.1/getting_started/installation/eshop_installation.html I would consider this as a sufficient option. [sp] |
|
|
Its not about the testing library, but about the test files, which are included in almost every composer package: vendor/oxid-esales/oxideshop-ce/tests vendor/oxid-esales/oxideshop-doctrine-migration-wrapper/tests vendor/oxid-esales/oxideshop-facts/tests vendor/oxid-esales/paypal-module/Tests etc. With the option "--prefer-dist" you can let composer to analyse .gitattributes file for "export-ignore" occurences and to shrink the package. For more details see https://madewithlove.be/gitattributes/ Its a wide-spread approach anyway: * https://github.com/zendframework/zend-http/blob/master/.gitattributes * https://github.com/laravel/framework/blob/master/.gitattributes * https://github.com/composer/composer/blob/master/.gitattributes |
|
|
see PL https://github.com/OXID-eSales/oxideshop_ce/pull/673 |
|
|
This feature has been rejected by the team and since there are good reasons not to separate tests and the code it is testing while at the same time there are easy ways for all projects to remove the tests for their distribution in the CI pipeline, we will not do this. |
