View Issue Details

IDProjectCategoryView StatusLast Update
0006839OXID eShop (all versions)6. ------ Setup -------public2018-06-08 10:44
ReporterHelmut L. 
PrioritynormalSeverityfeatureReproducibilityalways
Status acknowledgedResolutionreopened 
Product Version6.0.2 
Target VersionFixed in Version 
Summary0006839: source-path parameter not fully working
DescriptionIf you set a source-path in the composer.json file, the shop is installed into that folder instead of the "source" folder. This already works, but there are some files in the shop in which the folder name is explicitly set to "source" despite the shop being installed into another folder.
This results in a fatal error when you try to open the shop.
Steps To Reproduce1. run composer in an empty directory to get a composer.json file:
composer create-project --no-dev --no-install --remove-vcs oxid-esales/oxideshop-project . dev-b-6.0-ee

2. set the source path:
composer config extra.oxideshop.source-path htdocs

3. install the shop:
composer install --no-dev

4. try to open the shop
Additional InformationSo far I've found this hard coded folder name in two files:
oxid-esales/oxideshop-ce/source/bootstrap.php, line 11
oxideshop-facts/src/Config/ConfigFile.php, line 58
TagsNo tags attached.
ThemeNot defined
BrowserNot defined
PHP VersionNot defined
MySQL VersionNot defined

Activities

QA

2018-06-07 16:10

administrator   ~0012496

The name of the source directory inside the shop directory is mandatory.

Helmut L.

2018-06-07 17:28

reporter   ~0012497

If the folder name must be "source" why was the source-path parameter added to change it?

QA

2018-06-07 17:52

administrator   ~0012498

Where did you get the parameter from?

Helmut L.

2018-06-07 18:01

reporter   ~0012499

In the abstract package installer are constants for the possible options that can be set through the composer.json file.

/vendor/oxid-esales/oxideshop-composer-plugin/src/Installer/Package/AbstractPackageInstaller.php, line 30:

    /** Used to decide what the shop source directory is. */
    const EXTRA_PARAMETER_SOURCE_PATH = 'source-path';

QA

2018-06-08 10:37

administrator   ~0012501

It is still in discussion, but it is currently not intended to change the source directory via this parameter.