View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006586 | OXID eShop (all versions) | 4.01. Database handling | public | 2017-02-09 16:08 | 2024-04-03 10:46 |
| Reporter | Paulius.Kupetis | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 4.10.2 / 5.3.2 | ||||
| Fixed in Version | 6.0.0-rc.2 | ||||
| Summary | 0006586: \oxBase::_update always returns true | ||||
| Description | \oxBase::_update always returns true. transforming object to boolean always gives true. ALSO in V6 shop this is partly fixed - execute returns number, so 0 can be transformed to false other numbers to true. BUT what this function intends to return? Maybe it would be better to return if sql was successful or not. not just if sql affected queries.. This affects some modules like ERP. | ||||
| Tags | No tags attached. | ||||
| Theme | Not defined | ||||
| Browser | Not defined | ||||
| PHP Version | All | ||||
| Database Version | All | ||||
|
|
Hello, looks like issue is fixed on 2017-03-28, now its eather true on success or DatabaseException on sql error. |
|
|
Fixed in https://github.com/OXID-eSales/oxideshop_ce/commit/64feb9e108798a0e6bc8566e00985818df1a17f9 |
