View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0006542 | OXID eShop (all versions) | 1.01. Products (product, categories, manufacturer, promotions etc.) | public | 2016-11-18 08:33 | 2022-01-28 11:50 |
Reporter | avalue | Assigned To | |||
Priority | normal | Severity | feature | Reproducibility | always |
Status | resolved | Resolution | won't fix | ||
Product Version | 4.10.2 / 5.3.2 | ||||
Summary | 0006542: page title is used instead of category title | ||||
Description | In flow's list template found under /application/views/flow/tpl/page/list/list.tpl Line 35 the SEO title is used to display the category name. This causes side-effects as SEO addons can modify the page title for seo optimization – but you do not want to display the meta title as category name. So in my opinion, better use [{$actCategory->getTitle()}] to get the title of the category, not the SEO title of the page in h1 tag. | ||||
Steps To Reproduce | 1. change the seo title of the category with any available seo addon 2. you will see the title is used inside an h1 tag | ||||
Tags | Solution Provided | ||||
Theme | Flow | ||||
Browser | Google Chrome | ||||
PHP Version | 5.6 | ||||
Database Version | Not defined | ||||
|
The $oView->getTitle() in both application/views/flow/tpl/page/list/list.tpl (line 35) and application/views/flow/tpl/layout/base.tpl(line 11) call application/controllers/alist.php::getTitle() method. This method returns the active category's title value. 1. Can you give an example or a situation where these two must differ. 2. What do you actually mean by SEO Title? |
|
1. For example you have a SEO manager and he wants to optimize the page title (<title> tag) but the h1 heading on the page itself should NOT change. This is actually impossible with that theme. The Method getTitle() implemented in alist.php is meant to return the page title (<title> tag) not the visible title of a Category as there is "oxCategory->getTitle()" for it. 2. <title> tag in meta informations |
|
Thank you for the information. I am changing the severity to a feature request. |
|
I created a pull request for this issue: https://github.com/OXID-eSales/flow_theme/pull/98 |
|
The pull request was once done and then reverted, because it caused side-effects. If this should still be implemented, the change must be more sophisticated. Please see pull request. In any case: This won't be fixed or changed for flow anymore. Also since the value comes from the controller, you can easily change what it would return anyway. |