View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006349 | OXID eShop (all versions) | 4.08. Cache | public | 2016-03-14 11:06 | 2024-03-06 14:02 |
| Reporter | keywan.ghadami | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 4.9.7 / 5.2.7 | ||||
| Fixed in Version | 6.0.0-beta.1 | ||||
| Summary | 0006349: Shop may flag output as cachable even if controller detected errors during rendering | ||||
| Description | Current situation is that cache headers are send before view is rendered. But in some situation the controller will only be able to tell if content is cacheable(and how long) after the content was generated. So Cache headers , and cachekeys (e.g. oxenvkey cookie) must be evaluated after rendering. | ||||
| Steps To Reproduce | - enable reverse proxy caching with an valid licence key with high performance option - debug and set breakpoints in a controller in methods - render - isCacheable - getCacheLifeTime - manipulate headers send by your browser to fake varnish ESI support - open the browser and trigger that controller by using the cl parameter you will see isCacheable getCacheLifeTime are called before the render method was executed | ||||
| Additional Information | I am going to patch the core file in the current affected project and will provide pull requests. | ||||
| Tags | Performance and Caching Rework | ||||
| Theme | Not defined | ||||
| Browser | Not defined | ||||
| PHP Version | Not defined | ||||
| Database Version | Not defined | ||||
