View Issue Details

IDProjectCategoryView StatusLast Update
0006349OXID eShop (all versions)4.08. Cachepublic2016-03-14 13:22
Reporterkeywan.ghadami 
PrioritynormalSeverityminorReproducibilityalways
Status acknowledgedResolutionopen 
Product Version4.9.7 / 5.2.7 
Target VersionFixed in Version 
Summary0006349: Shop may flag output as cachable even if controller detected errors during rendering
DescriptionCurrent situation is that cache headers are send before view is rendered.
But in some situation the controller will only be able to tell if content is cacheable(and how long) after the content was generated. So Cache headers , and cachekeys (e.g. oxenvkey cookie) must be evaluated after rendering.
Steps To Reproduce- enable reverse proxy caching with an valid licence key with high performance option
- debug and set breakpoints in a controller in methods
 - render
 - isCacheable
 - getCacheLifeTime
- manipulate headers send by your browser to fake varnish ESI support
- open the browser and trigger that controller by using the cl parameter

you will see isCacheable getCacheLifeTime are called before the render method was executed
Additional InformationI am going to patch the core file in the current affected project and will provide pull requests.
TagsNo tags attached.
ThemeNot defined
BrowserNot defined
PHP VersionNot defined
MySQL VersionNot defined

Activities

There are no notes attached to this issue.