View Issue Details

IDProjectCategoryView StatusLast Update
0006284OXID eShop (all versions)1.02. Price calculations (discounts, coupons, additional costs etc.)public2015-12-28 12:57
Reportermichael_keiluweit 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version4.9.6 / 5.2.6 
Target VersionFixed in Version6.0.0-beta.1 
Summary0006284: It's possible to generate coupons without a coupon number
DescriptionDuring the generation of coupons it isn't checked if the field for the coupon number was filled. So it's possible to generate coupons without a coupon number.

The basket prevents you from activating a coupon without a number. But if you disable javascript in your browser, then you can just click the button "submit coupon" and you will get the coupon which hasn't a number.

So we have two situations here:

Either the backend has to be improved that coupons must have at least one char or the basket must accept empty codes even if javascript is activated.
Steps To Reproducebackend

1. Shop settings -> Coupon Series -> Create new Coupon Serie
2. add a discount, give it a name, save it
3. now, activate the radio box for the field "Coupon Number" but let the input field blank
4. type a number for the field "Quantity"
5. save it


frontend

1. put an article in the basket
2. goto basket
3. disable javascript
4. click the button "submit button"
Additional InformationPlease note: This will only work if there is at least one coupon serie which was generated without a coupon number.


If the solution will be that you can't generate a coupon serie without a coupon number, then the basket must give the users with disabled javascript an error message that the field for the coupon code musst be filled. Currently only users with activated javascript will get an error message - users without javascript not.
TagsNo tags attached.
ThemeAzure
BrowserNot defined
PHP VersionNot defined
MySQL VersionNot defined

Activities

QA

2015-12-10 16:08

administrator   ~0011373

Last edited: 2015-12-10 16:08

View 2 revisions

There is a pull-request related to this issue: https://github.com/OXID-eSales/oxideshop_ce/pull/301

mantas.vaitkunas

2015-12-28 12:56

administrator   ~0011394

https://github.com/OXID-eSales/oxideshop_ce/pull/301