0006132: POST to /index.php?cl=1 caused by redirect in the answers to the IPN call back causes exceptions - OXID eShop bugtrack

ID	Project	Category	View Status	Date Submitted	Last Update

0006132	module PayPal	module PayPal - sub	public	2015-04-23 12:55	2019-04-18 17:56

Reporter	keywan.ghadami	Assigned To
Priority	normal	Severity	tweak	Reproducibility	always
Status	resolved	Resolution	fixed
Product Version	3.2.1
Fixed in Version	5.2.4

Summary	0006132: POST to /index.php?cl=1 caused by redirect in the answers to the IPN call back causes exceptions
Description	when doing checkout with paypal, paypal module sends a correct notify to paypal. e.g. somethink like: https://yourdomain.com/index.php?cl=oePayPalIPNHandler&fnc=handleRequest&shp=1 after that paypal will make requests to this url. Now the paypal module handles this request and on success it returns true to the calling shop framework which causes a redirect, that will force paypal to resend the request to a wrong url like this: POST /index.php?cl=1&sid=oqh17aa4e53bhou6ea0r2koqn4 the "1" in the cl paramters is the true value returned by the paypal module in the handle request method.
Steps To Reproduce	make a checkout with paypal, wait for the IPN call, and see the log files, in access logs you will see several requests from the paypal server, correct one first then the broken requests caused by the redirect.
Additional Information	FILE: htdocs\modules\oe\oepaypal\controllers\oepaypalipnhandler.php FUNKTION: public function handleRequest LINE: 153 Solution: do not return boolean, instead return null. Pitfalls: the redirect/bug stops the execution right after the IPN messages is handled. It might be necessary to something similar because else the shop framework may do other unwanted things.
Tags	No tags attached.