View Issue Details

IDProjectCategoryView StatusLast Update
0005894OXID eShop (all versions)4.11. Image handlingpublic2014-11-26 12:32
Reporterflowcontrol 
PrioritynormalSeveritytweakReproducibilityalways
Status resolvedResolutionfixed 
Product Version4.8.4 / 5.1.4 
Target Version4.9.3 / 5.2.3Fixed in Version6.0.0-beta.1 
Summary0005894: File locking and unlocking not clean
DescriptionIn Method oxDynImgGenerator::_lock() the call
fclose( $rHandle );
should be
fclose( $this->_hLockHandle );

also you should set
$this->_hLockHandle
to NULL in that case becouse the handle still resides in this variable even after the call you
fclose()


In Method oxDynImgGenerator::_unlock() the if statement should be:
if ( is_resource($this->_hLockHandle) )
TagsImage Conversion
ThemeAzure
BrowserAll
PHP Versionany
MySQL Versionany

Activities

jurate.baseviciene

2014-09-30 16:34

reporter   ~0010205

Reminder sent to: flowcontrol

Hi,

 As we saw, you already submitted a complete solution for this issue. If you feel fancy, you'd also have the possibility to contribute your changes directly to our GitHub repository on https://github.com/OXID-eSales/oxideshop_ce/. Please leave a note there with the bug number you fixed so we can close this issue in the bug tracker."

Best regards

martinwegele

2014-11-25 15:12

reporter   ~0010351

pull request: https://github.com/OXID-eSales/oxideshop_ce/pull/189

saulius.stasiukaitis

2014-11-26 12:32

reporter   ~0010356

Fixed from pull request https://github.com/OXID-eSales/oxideshop_ce/pull/189