View Issue Details

IDProjectCategoryView StatusLast Update
0005746OXID eShop (all versions)2.3. Extensions (modules, themes)public2021-02-05 14:22
Reporteraurimas.gladutis Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version4.6.7 
Fixed in Version7.0.0-rc1 
Summary0005746: Timestamp is not added for css and js files included from module
DescriptionCurrently when including js or css file from module, you usually do it like this:
[{oxstyle include=$oViewConf->getModuleUrl('module','path/to/file.css')}]

Now getModuleUrl creates full path to file (including host http://host.com/) and both oxstyle and oxscript plugins checks whether included file starts with http (which it does), and if so - does not add any filetime to the end.
This is done so that filetime would not be added to files from other server, but the check itself is incorrect.

This check should check if the domain is actually different, not only if the full path is specified.
TagsSolution Provided
ThemeAll
BrowserAll
PHP VersionNot defined
Database VersionNot defined

Activities

alfredbez

2016-10-07 11:06

reporter   ~0011827

Pull Request: https://github.com/OXID-eSales/oxideshop_ce/pull/493

anton.fedurtsya

2021-02-05 14:22

administrator   ~0013377

Hey guys, the suggested PR have been recently merged. Thanks for the fix!