View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005746 | OXID eShop (all versions) | 2.3. Extensions (modules, themes) | public | 2014-04-29 15:41 | 2021-02-05 14:22 |
| Reporter | aurimas.gladutis | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 4.6.7 | ||||
| Fixed in Version | 7.0.0-rc1 | ||||
| Summary | 0005746: Timestamp is not added for css and js files included from module | ||||
| Description | Currently when including js or css file from module, you usually do it like this: [{oxstyle include=$oViewConf->getModuleUrl('module','path/to/file.css')}] Now getModuleUrl creates full path to file (including host http://host.com/) and both oxstyle and oxscript plugins checks whether included file starts with http (which it does), and if so - does not add any filetime to the end. This is done so that filetime would not be added to files from other server, but the check itself is incorrect. This check should check if the domain is actually different, not only if the full path is specified. | ||||
| Tags | Solution Provided | ||||
| Theme | All | ||||
| Browser | All | ||||
| PHP Version | Not defined | ||||
| Database Version | Not defined | ||||
|
|
Pull Request: https://github.com/OXID-eSales/oxideshop_ce/pull/493 |
|
|
Hey guys, the suggested PR have been recently merged. Thanks for the fix! |
