View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005621 | OXID eShop (all versions) | 2. ----- eShop backend (admin) ----- | public | 2014-01-24 14:17 | 2023-11-24 09:19 |
| Reporter | mark | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | no change required | ||
| Product Version | 4.8.1 / 5.1.1 | ||||
| Summary | 0005621: malformed script breaks session in admin (only FireFox + EE) | ||||
| Description | Some admin templates include bottomitem.tpl like this: [{include file="bottomitem.tpl"}] and this bottomitem contains this line: [{ oxscript }] Now the problem: Latest changes to core/smarty/plugins/function.oxscript.php (EE only) force the shop to include the oxwidgetshandler.js, which fails in admin template. So please change line 103 and include isAdmin in the if condition or change _oxscript_include (line 154) adding ' && $sSrc !== ""' to the if condition. This (both fixes) avoid oxid to write the following line to the html sourcecode which leads to this error: <script type="text/javascript" src=""></script> This line breaks the session (Firefox only) | ||||
| Steps To Reproduce | 1) Login to a enterprise demoshop admin with Firefox and varnish activated (RP->isActive) 2) Go to Artikel -> Artikel verwalten 3) Choose random article from list 4) switch to another tab | ||||
| Tags | Varnish | ||||
| Theme | Not defined | ||||
| Browser | Not defined | ||||
| PHP Version | Not defined | ||||
| Database Version | Not defined | ||||
|
|
Reminder sent to: mark Hi, Thanks a lot for submitting this issue, but unfortunately we can not reproduce this issue. Step how we try reproduce: 1) Login to a enterprise admin with Firefox (version 26.0) and varnish activated (RP->isActive) 2) Then we go to Administer Products->Products 3) Choose product 1402 4) Go to "Extended" tab And we see that everything work as expected, we does not see that session is breaks. So please explain more detailed how need to reproduced this issue? Maybe we missed something... Best regards |
|
|
Hi! Anyhow - can you see <script type="text/javascript" src=""></script> in the source of the iframe? best regards, Mark |
|
|
Hi, the case here is that varnish configuration supplied by us should pass through admin requests and RP->isActive() here would then return false, so as long as admin requests is not going through varnish, this problem should not appear. |
|
|
We added this tweak: if (isAdmin()) { $_SERVER["HTTP_SURROGATE_CAPABILITY"] = 'varnish=ESI'; } in config bootstrap process to allow using some varnish functions in admin (like checking if its available or purging after changing sth in admin |
