0005610: Bundled products will be deleted from their orders after using forms in order_main or order_article - OXID eShop bugtrack

ID	Project	Category	View Status	Date Submitted	Last Update

0005610	OXID eShop (all versions)	2.6. Administer orders	public	2014-01-18 22:36	2023-11-24 09:14

Reporter	Mitmacher	Assigned To
Priority	normal	Severity	major	Reproducibility	always
Status	acknowledged	Resolution	open
Product Version	4.8.1 / 5.1.1

Summary	0005610: Bundled products will be deleted from their orders after using forms in order_main or order_article
Description	If you have orders with bundled products then edit these orders in the backend and you will see that the bundles have been deleted magically.
Steps To Reproduce	1. create an article bundle 2. order this article and reopen backend 3. in order_overview and order_articles the bundle is listed correctly 4. click "Save" in order_main or "Update" in order_articles 5. the bundle has been deleted from its order!
Additional Information	Please look at the function addOrderArticleToBasket(...) in oxbasket.php. Since OXID 4.5.x there is an if statement wich causes this problem: if ( $oOrderArticle->oxorderarticles__oxamount->value > 0 && !$oOrderArticle->isBundle() ) { ... } elseif ( $oOrderArticle->isBundle() ) { // deleting bundles, they are handled automatically $oOrderArticle->delete(); } So, if you simply delete "&& !$oOrderArticle->isBundle()", everything seems to work as expected again. But what's the reason for the comment? I neither can't find such automatism nor it seems to work. Bundles are just deleted.
Tags	Product domain and basket rewrite

Theme	All
Browser	All
PHP Version	Not defined
Database Version	Not defined

svetlana 2014-01-20 15:46 reporter ~0009429	Reminder sent to: Mitmacher Hi, We have a question to make sure how you reproducing the bug. Does the discount with bundle product is still active and the expiration date is still valid for this discount during you make update in the admin? Because I can reproduce this issue in this case: 1. create discount with the item. 2. purchase product with item discount. 3. deactivate created discount 4. in admin update the order.

Mitmacher 2014-01-20 16:18 reporter ~0009430	Hi, no, it is also reproducable if the bundle is still active! The funny thing is that if you delete the article (to which the deleted one was bundled) and re-add it again in admin, than the bundle is also re-added. But if you than update the order once more (without change) it is deleted again! Crazy ;-)

Mitmacher 2014-01-20 22:45 reporter ~0009432	Ah, now I see: I don't meant discount bundles, but the simple variant to bundle one article to another in product admin. I didn't recognize there are two ways of creating so-called bundles, sorry! ;) But I've created a summarized (german) forum thread for all the problems with updating orders in admin: http://forum.oxid-esales.com/showthread.php?t=21886 Thanks for relating to 0004624, because I didn't find all those topics before! :)

henrik.steffen 2018-03-05 10:40 reporter ~0012410	Would be great if this annoying issue could actually be solved, more than 4 years after reporting it.