View Issue Details

IDProjectCategoryView StatusLast Update
0005416OXID eShop (all versions)4.07. Source code, Testpublic2014-04-15 15:18
ReporterMatthias Hellweg 
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version4.8.0_5.1.0_beta1 
Target Version4.9.0_5.2.0_beta1Fixed in Version4.8.5 / 5.1.5 
Summary0005416: Check for subscription status in oxNewsSubscribed via "wasUnsubscribed()" is flawed
DescriptionThe function "wasUnsubscribed" in the class "oxNewsSubscribed" contains an error that generally leads to invalid return values.

if ( '0000-00-00 00:00:00' != $this->oxnewssubscribed__oxunsubscribed )

should be

if ( '0000-00-00 00:00:00' != $this->oxnewssubscribed__oxunsubscribed->value )
Additional InformationIntroduced in Oxid CE 4.5.0
Found in Oxid CE 4.5.0 to 4.8.0 and respective EE versions
TagsNo tags attached.
ThemeAll
BrowserAll
PHP Versionany
MySQL Versionany

Activities

Matthias Hellweg

2013-09-18 12:58

reporter   ~0009095

Introduced in CE 4.5.9 (not 4.5.0)

jurate.baseviciene

2013-09-18 13:27

reporter   ~0009096

Reminder sent to: Matthias Hellweg

Hi,

Thank you very much for your bug report. As we saw, you already submitted a complete solution for this issue. If you feel fancy, you'd also have the possibility to contribute your changes directly to our GitHub repository on https://github.com/OXID-eSales/oxideshop_ce/. [^] Please leave a note there with the bug number you fixed so we can close this issue in the bug tracker.


Best regards

tadas

2014-02-20 16:32

reporter   ~0009558

Added the change, it would pass even strict comparison.