View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005416 | OXID eShop (all versions) | 4.07. Source code, Test | public | 2013-09-18 12:49 | 2014-04-15 15:18 |
| Reporter | Matthias Hellweg | Assigned To | |||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 4.8.0_5.1.0_beta1 | ||||
| Target Version | 4.9.0_5.2.0_beta1 | Fixed in Version | 4.8.5 / 5.1.5 | ||
| Summary | 0005416: Check for subscription status in oxNewsSubscribed via "wasUnsubscribed()" is flawed | ||||
| Description | The function "wasUnsubscribed" in the class "oxNewsSubscribed" contains an error that generally leads to invalid return values. if ( '0000-00-00 00:00:00' != $this->oxnewssubscribed__oxunsubscribed ) should be if ( '0000-00-00 00:00:00' != $this->oxnewssubscribed__oxunsubscribed->value ) | ||||
| Additional Information | Introduced in Oxid CE 4.5.0 Found in Oxid CE 4.5.0 to 4.8.0 and respective EE versions | ||||
| Tags | No tags attached. | ||||
| Theme | All | ||||
| Browser | All | ||||
| PHP Version | any | ||||
| Database Version | any | ||||
|
|
Introduced in CE 4.5.9 (not 4.5.0) |
|
|
Reminder sent to: Matthias Hellweg Hi, Thank you very much for your bug report. As we saw, you already submitted a complete solution for this issue. If you feel fancy, you'd also have the possibility to contribute your changes directly to our GitHub repository on https://github.com/OXID-eSales/oxideshop_ce/. [^] Please leave a note there with the bug number you fixed so we can close this issue in the bug tracker. Best regards |
|
|
Added the change, it would pass even strict comparison. |