View Issue Details

IDProjectCategoryView StatusLast Update
0005355OXID eShop (all versions)1.01. Products (product, categories, manufacturer, promotions etc.)public2014-02-25 09:05
Reporterarvydas_vapsva 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version4.7.6 / 5.0.6 
Target Version4.8.5 / 5.1.5Fixed in Version4.9.0_5.2.0_beta1 
Summary0005355: .htaccess should be improved
DescriptionNow .htaccess contains this:

RewriteCond %{REQUEST_URI} (\/out\/pictures\/)
RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteRule (\.jpe?g|\.gif|\.png)$ getimg.php

In case in any of subfolders image is missing - image generator handler is executed.

I suppose should be better to change:

RewriteCond %{REQUEST_URI} (\/out\/pictures\/)

to:

RewriteCond %{REQUEST_URI} (\/out\/pictures\/generated\/)
Tagshtaccess
ThemeBoth
BrowserAll
PHP Versionany
MySQL Versionany

Activities

jurate.baseviciene

2013-08-23 07:19

reporter   ~0008982

Reminder sent to: arvydas_vapsva

Hi,

Thank you very much for your bug report. As we saw, you already submitted a complete solution for this issue. If you feel fancy, you'd also have the possibility to contribute your changes directly to our GitHub repository on https://github.com/OXID-eSales/oxideshop_ce/. Please leave a note there with the bug number you fixed so we can close this issue in the bug tracker.


Best regards

tadas

2014-02-25 09:05

reporter   ~0009594

Added 'generated' to rewrite condition so that it would only go through getimg.php if it image is being called through generated folder.