View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005347 | OXID eShop (all versions) | 1.02. Price calculations (discounts, coupons, additional costs etc.) | public | 2013-08-20 15:12 | 2014-03-04 11:28 |
| Reporter | itsabug | Assigned To | |||
| Priority | high | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | unable to reproduce | ||
| Product Version | 4.7.6 / 5.0.6 | ||||
| Summary | 0005347: isForBasketItem not returning boolean when checking for category discount | ||||
| Description | According to oxid documentation oxBasketItem::isForBasketItem returns a boolean value. This is not true when the method checks for category based discounts. When $blOk = $this->_checkForArticleCategories( $oArticle ); is triggered (Line 175), $blOk is assigned with a return value from an getOne statement. In this case $blOk holds either an oxid or theoretically NULL. This can lead to faulty discount calculations when you check for isForBasketItem() === true. | ||||
| Steps To Reproduce | Trigger $this->_checkForArticleCategories( $oArticle ); and check the return value. | ||||
| Tags | No tags attached. | ||||
| Theme | Both | ||||
| Browser | All | ||||
| PHP Version | any | ||||
| Database Version | any | ||||
|
|
Reminder sent to: itsabug Hi, Thanks a lot for submitting this issue, but unfortunately we can not reproduce this issue. If there still is a problem, maybe you could send us more details about it? Because if we try to reproduce this case then isForBasketItem is returning bool when checking for category discount, never return value NULL. Best regards |
