View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005310 | OXID eShop (all versions) | 1.05. Users | public | 2013-07-24 13:34 | 2014-04-15 10:25 |
| Reporter | martinwegele | Assigned To | |||
| Priority | normal | Severity | trivial | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 4.1.0 revision 17976 | ||||
| Fixed in Version | 4.8.5 / 5.1.5 | ||||
| Summary | 0005310: superfluous if statement in Newsletter::removeme() | ||||
| Description | Newsletter::removeme() removes the user only from the newsletter group if the setting for double opt in (blOrderOptInEmail) is not active. There are other places (e.g. Account_Newsletter::subscribe) where a cancellation of the newsletter is possible but there no check for this setting is done and the user is removed from the group. According to Linas's code review the if statement in Newsletter::remove is not needed and can be removed. | ||||
| Additional Information | Probably this has been like that forever, at least since version 4.1.0. | ||||
| Tags | No tags attached. | ||||
| Theme | All | ||||
| Browser | All | ||||
| PHP Version | any | ||||
| Database Version | any | ||||
|
|
Account_Newsletter::subscribe works correct. It allow subscription to newsletter for logged and not logged user. It always allow unsubscribe, but subscription depends on configuration. blOrderOptInEmail requires confirmation from email. Newsletter::removeme allow user unsubscribe from newsletter. Data in table oxobject2group do not change if blOrderOptInEmail is checked and unsubscribe from newsletter link. |
