View Issue Details

IDProjectCategoryView StatusLast Update
0000527OXID eShop (all versions)5. ------ UpdateApp / Update ------public2012-12-10 13:31
Reporterandreas_ziethen Assigned To 
PriorityurgentSeveritycrashReproducibilityalways
Status resolvedResolutionfixed 
Product Version4.0.0.2 revision 14842 
Fixed in Version4.0.1.0 revision 15990 
Summary0000527: Users without password cannot register - bug in update script generates wrong passwords
DescriptionThe update script (patch from 4.0.0.1_14455 to 4.0.0.2_14842) has a critcical bug: it generates salted passwords for users who did not have any password before. So such users can't register or buy anything in the shop.

The bug is located in update.php in line 176:
$sQ = "update oxuser set oxpassword = MD5( CONCAT( oxuser.oxpassword, UNHEX( oxuser.oxpasssalt ) ) ) where LENGTH( oxuser.oxpassword ) < 32 and oxuser.oxpassword not like 'ox\_%' and oxuser.oxpasssalt != '' limit {$iQty}";

Users without any password do get one here because the old password (empty) is concated with the new salt.
TagsNo tags attached.
Theme
BrowserAll
PHP Version5.2.6
Database Version5.0.33

Activities

arvydas_vapsva

2009-01-26 13:50

reporter   ~0000398

FIX:

# restoring accounts without password
UPDATE oxuser SET oxpasssalt = '', oxpassword = '' WHERE oxpassword != '' AND oxpasssalt != '' AND UNHEX( oxpasssalt ) IS NOT NULL AND oxpassword = MD5( CONCAT( '', UNHEX( oxpasssalt ) ) );

arvydas_vapsva

2009-01-26 13:50

reporter   ~0000399

fixed