View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005264 | OXID eShop (all versions) | 4.03. 3rd party libraries | public | 2013-06-28 15:25 | 2022-01-28 14:13 |
| Reporter | FibreFoX | Assigned To | |||
| Priority | normal | Severity | feature | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 4.7.6 / 5.0.6 | ||||
| Summary | 0005264: Update tcpdf to latest revision | ||||
| Description | the shipped tcpdf-library is over 3 years old, in 3 monts its even 4 years old. There are lot of bugfixes in the current version, even better support of PHP 5.3 One nice feature of that newer version would be to have smaller pdf-files by subsetting the choosen font. The licence has changed to GNU-LGPLv3 | ||||
| Additional Information | 6.0.000 (2013-03-17) - IMPORTANT: PHP4 support has been removed starting from this version. 5.2.000 (2010-06-02) - IMPORTANT: Support for font subsetting was added by default to reduce the size of documents using large unicode font files. If you embed the whole font in the PDF, the person on the other end can make changes to it even if he didn't have your font. If you subset the font, file size of the PDF will be smaller but the person who receives your PDF would need to have your same font in order to make changes to your PDF. http://sourceforge.net/projects/tcpdf/files/ | ||||
| Tags | 3rd Party Libraries | ||||
| Theme | All | ||||
| Browser | All | ||||
| PHP Version | Not defined | ||||
| Database Version | Not defined | ||||
|
|
waiting for the PO decision. |
|
|
any progress on this one? there are a lot of bugs fixed in latest version, it's even made available via github now |
|
|
We are looking through all 3rd party libraries and evaluating them. All changes will be presented with the Next Major Version. |
|
|
Subsetting would be a great feature! File size of invoices in oxid eshop are pretty large!!! |
|
|
@Heinrich.Franz To reduce filesize, we currently break update-compatibility by replacing core/oxpdf.php::SetFont with this code public function SetFont($family, $style='', $size=0, $fontfile='') { // make PDFs smaller (font-subsetting not working with that ancient version of TCPDF) parent::SetFont("", $style, $size, $fontfile); } Beware of problems with UTF-8 here, default fallbacks are used by this |
|
|
What do you mean with problems with UTF-8? Characters other than latin? |
|
|
@Heinrich.Franz This works, because TCPDF falls back to "helvetica" instead of Arial, which is another font and might not look like expected (because the letters have different spacings). |
|
|
@FibreFoX I've already changed the code like you wrote and seen the result. But what are the problems with UTF-8? |
|
|
@Heinrich.Franz Might have been a problem on our side ;) can't reproduce it right now. If everything works okay, thats one problem less to consider. |
|
|
tcpdf is no longer part of the shop core, but moved to an external module: https://github.com/OXIDprojects/pdf-invoice-module/ According to https://github.com/OXIDprojects/pdf-invoice-module/blob/master/core/tcpdf/README.TXT it is now a newer version, but there were changes to the library files without updating the README... Anyway. I will close this ticket as we do no longer officially support this here. |
