View Issue Details

IDProjectCategoryView StatusLast Update
0005099OXID eShop (all versions)1.03. Basket, checkout processpublic2013-07-30 14:25
Reportertorsten.dix 
PrioritynormalSeverityfeatureReproducibilityalways
Status resolvedResolutionfixed 
Product Version4.7.5 / 5.0.5 
Target VersionFixed in Version4.7.7 / 5.0.7 
Summary0005099: Vouchertimeout not adjustable
DescriptionThe timeout for vouchers is set to 3 hours in the code of oxvoucher.php
Im many cases this is to long, for example, is a user has lost his session and will try to start his order again.
So this time should be configurable in the config.inc.php.
Steps To ReproduceCan be always reproduced, when a voucher has been put to the basket and the browser is restarted after this.
Additional InformationWe have made the following core-Patch to solve this problem:
config.inc.php:
$this->iVoucherTimeout = 900;
oxvoucher.php:

New method:
protected function _getVoucherTimeout() {
   return
     intval(oxRegistry::getConfig()->getConfigParam( 'iVoucherTimeout' )) ?
     intval(oxRegistry::getConfig()->getConfigParam( 'iVoucherTimeout' )) :
     3 *3600;
}

Replacement of (3 * 3600) in getVoucherByNr(..) and _isNotReserved() by $this->_getVoucherTimeout()
TagsNo tags attached.
ThemeBoth
BrowserAll
PHP Versionany
MySQL Versionany

Activities

mark

2013-06-27 09:32

reporter   ~0008842

made a pull request on github

Linas Kukulskis

2013-07-04 13:59

reporter   ~0008877

https://github.com/OXID-eSales/oxideshop_ce/pull/36