View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004890 | OXID eShop (all versions) | 4.07. Source code, Test | public | 2013-02-04 09:15 | 2023-11-17 14:06 |
| Reporter | Linas Kukulskis | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 4.7.3 / 5.0.3 revision 54408 | ||||
| Fixed in Version | 4.6.0 revision 44406 | ||||
| Summary | 0004890: remove method oxArticle::isNotBuyable() | ||||
| Description | remove "oxArticle::isNotBuyable()" and leave only "oxArticle::isBuyable()". This will lead to code refactoring. (see https://bugs.oxid-esales.com/view.php?id=3092, https://bugs.oxid-esales.com/view.php?id=1655) | ||||
| Tags | No tags attached. | ||||
| Theme | Not defined | ||||
| Browser | All | ||||
| PHP Version | Not defined | ||||
| Database Version | Not defined | ||||
|
|
It is not necessary to remove the method. isBuyable is already (from version 4.6 at least) only a negation of "isNotBuyable". The only thing that differs is that something might also be not buyable if the parent is not buyable https://github.com/OXID-eSales/oxideshop_ce/blob/3cd732605ea823d8276e48156440b62584c57101/source/Application/Model/Article.php#L773 |
