View Issue Details

IDProjectCategoryView StatusLast Update
0004671OXID eShop (all versions)4.07. Source code, Testpublic2012-12-18 15:51
Reportertjungcl 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version4.6.5 revision 49955 
Target Version4.7.2 / 5.0.2 revision 53018Fixed in Version4.7.3 / 5.0.3 revision 54408 
Summary0004671: delivery address md5 function not extendable
Descriptionthe new feature that checks the delivery address for modifications is not extendable without overwriting the functions totally.

So, if i want to add a new field to the md5 checksum, i have to overwrite two functions without calling parent::...

You should move the checksum generation to the classes oxaddress and oxuser.
The string, that is checksummed should be constructed in private functions that return only the concatinated field values, so that is what users can extend, when they want more fields in the checksum.

oxorder.php and order.php then would call those md5s.

Btw: the name of the function and hidden parameter is misleading. Its not the deliveryaddress checksum, it is the checksum of both billing and delivery address.

TagsNo tags attached.
ThemeBoth
BrowserAll
PHP Versionany
MySQL Versionany

Activities

aurimas.gladutis

2012-12-18 15:51

reporter   ~0008170

Added additional functions and moved them to oxaddress and oxuser to make extending easier.