View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0004002 | OXID eShop (all versions) | 2. ----- eShop backend (admin) ----- | public | 2012-05-06 12:26 | 2012-05-18 10:45 |
Reporter | WBL_BjoernLange | Assigned To | |||
Priority | high | Severity | tweak | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Product Version | 4.6.0 revision 44406 | ||||
Fixed in Version | 4.6.1 revision 45706 | ||||
Summary | 0004002: Redundancy in oxModule::deactivate | ||||
Description | oxModule::deactivate works with numeric Arrays to merge the freshly deactivated Module-ID with "aDisabledModules" and lets the array grow infinitely "Values in the input array with numeric keys will be renumbered with incrementing keys starting from zero in the result array." http://php.net/array_merge There is a missing in_array or array_unique call in if (isset($sModuleId)) { $aDisabledModules = $this->getDisabledModules(); if (!is_array($aDisabledModules)) { $aDisabledModules = array(); } $aModules = array_merge($aDisabledModules, array($sModuleId)); $this->getConfig()->saveShopConfVar('arr', 'aDisabledModules', $aModules); $this->getConfig()->setConfigParam('aDisabledModules', $aModules); | ||||
Tags | No tags attached. | ||||
Theme | Both | ||||
Browser | All | ||||
PHP Version | any | ||||
Database Version | any | ||||