View Issue Details

IDProjectCategoryView StatusLast Update
0003804OXID eShop (all versions)4.07. Source code, Testpublic2012-12-18 16:04
Reportermichael_keiluweit 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version4.5.9 revision 43186 
Target Version4.6.6 revision 54646Fixed in Version4.6.6 revision 54646 
Summary0003804: White space between words will removed (maybe wrong method description)
Descriptionhi,

method descriptions of oxtagcloud::trimTags() says:

    /**
     * Trims underscores and spaces from tags.
     *
     * @param string $sTags given tag
     *
     * @return string
     */

But the regular expression remove also white spaces, please see attached screenshot.
Now, I am not sure, if it's a bug or the description is not complete.
Additional Informationchecked the regular expression at http://www.gethifi.com/tools/regex

([\s\,\-]?)([^\s\,\-]+)([\s\,\-]?)
TagsTags
ThemeBoth
BrowserAll
PHP Versionany
MySQL Versionany

Activities

michael_keiluweit

2012-04-03 12:42

developer  

regular_expression.png (29,702 bytes)
regular_expression.png (29,702 bytes)

aurimas.gladutis

2012-12-17 16:39

reporter   ~0008145

You probably ment dashes, not spaces.
This function trims spaces from tags, removes incorrect commas, dashes and underscores, and that is how we updated the comment.