View Issue Details

Jump to Notes
IDProjectCategoryView StatusDate SubmittedLast Update
0000357OXID eShop (all versions)4.07. Source code, Testpublic2008-10-27 18:012012-12-10 13:45
Reportertomas_liubinas Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Fixed in Version4.0.0.0 revision 14260 
Summary0000357: $blAllowUnevenAmounts parameter is unneded for oxBasket::addToBasket()
DescriptionoxBasket::addToBasket() is one of most often overriden methods in modules. At the moment besides $sProductID, $dAmount parameter it has $blAllowUnevenAmounts mandatory parameter. It is not necessary at all. $blAllowUnevenAmounts should be read from Config option not from function parameter.
TagsNo tags attached.
Theme
BrowserAll
PHP Version5.2.6
Database Version5.0.33

Activities

tomas_liubinas

2008-11-04 16:01

reporter   ~0000227

I noticed later, that this problem applies not only to single method but to more of them. This parameter should be removed from all method declarations.

vilma_liorensaityte

2008-11-04 17:17

reporter   ~0000228

removed from calculateBasket() $blExclNonMaterial (exclude non material articles) too