View Issue Details

IDProjectCategoryView StatusLast Update
0003432OXID eShop (all versions)1.02. Price calculations (discounts, coupons, additional costs etc.)public2012-12-07 15:19
Reportertjungcl 
PriorityhighSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version4.5.5 revision 40299 
Target VersionFixed in Version4.7.0_5.0.0_beta3 
Summary0003432: discount in netPriceMode wrong
Descriptionthe function applyDiscount in class oxdiscount adds a new oDiscountPrice to the existing oPrice. The oDiscountPrice is always in bruttoMode, using wrong logic for rounding.

Especially in the case of procentual discounts, its obvious: the function reads bruttoPrice from the oPrice (which is in nettoMode), using it to calc the rounded bruttoPrice of oDiscountPrice, which is then added to oPrice.

Instead the function has to check, if oPrice is in netMode, and if it is, it has to set the nettoprice of oDiscountPrice and read the nettoprice of oPrice, too.

TagsVAT
ThemeBoth
BrowserAll
PHP Versionany
MySQL Versionany

Activities

svetlana

2012-06-08 17:04

reporter   ~0006830

@developers: please check from the source code, do we need this fix, can we improve something here?

Linas Kukulskis

2012-09-26 15:29

reporter   ~0007497

changed discount calculation